Yang-models interface name length validation#20108
Merged
qiluo-msft merged 12 commits intosonic-net:masterfrom Nov 22, 2024
Merged
Yang-models interface name length validation#20108qiluo-msft merged 12 commits intosonic-net:masterfrom
qiluo-msft merged 12 commits intosonic-net:masterfrom
Conversation
This was referenced Sep 3, 2024
nazariig
approved these changes
Sep 3, 2024
Contributor
Author
|
/azpw ms_conflict |
2 similar comments
Contributor
Author
|
/azpw ms_conflict |
Contributor
Author
|
/azpw ms_conflict |
qiluo-msft
reviewed
Sep 9, 2024
Modify the valid tunnel name test to use 15 chars tunnel name
Modify the valid tunnel name test to use 15 chars tunnel name
qiluo-msft
approved these changes
Sep 21, 2024
This was referenced Oct 17, 2024
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Dec 2, 2024
This PR is accompanied by sonic-net/sonic-swss-common#931 and sonic-net/sonic-buildimage#20108 What I did Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions. How I did it Add validation checks in the relevant config functions for the following interface types: vxlan vlan vrf loopback subinterface portchannel How to verify it UT tests added Previous command output (if the output of a command-line utility has changed) New command output (if the output of a command-line utility has changed)
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-utilities#3397 Why I did it Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions. How I did it Add validation checks in the relevant yang-model definitions for the following interface types: vxlan vlan vrf loopback subinterface portchannel How to verify it UT added
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
This PR is accompanied by sonic-net/sonic-swss-common#931 and sonic-net/sonic-buildimage#20108 What I did Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions. How I did it Add validation checks in the relevant config functions for the following interface types: vxlan vlan vrf loopback subinterface portchannel How to verify it UT tests added Previous command output (if the output of a command-line utility has changed) New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-utilities#3397
Why I did it
Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.
Work item tracking
How I did it
Add validation checks in the relevant yang-model definitions for the following interface types:
vxlan
vlan
vrf
loopback
subinterface
portchannel
How to verify it
UT added
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)