[build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages#3328
Conversation
…en urllib3 and requests packages
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…en urllib3 and requests packages (sonic-net#3328) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
|
Can this be backported to 202305 too, please? |
|
Can this be backported to 202211 as well ? Thank you |
|
@yxieca, the same build issue is observed on 202205 branch, could you please help to check if we need to cherry-pick this fix to 202205? |
|
@volodymyrsamotiy seems that we need separate PR for 202205 branch. |
|
@yxieca should we raise a seperate PR for 202211 as well? Pls let me know how to go about it. We are using 202211 branch actively |
…en urllib3 and requests packages (sonic-net#3328) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
…en urllib3 and requests packages (sonic-net#3328) (sonic-net#3337) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
|
hi @oleksandrivantsiv @dgsudharsan cherry pick conflict for 202305, could you file separate PR? |
|
@StormLiangMS We already have the PR open #3351 |
…en urllib3 and requests packages (sonic-net#3328)
@yxieca, I created 202205 PR - #3355 [cherry-pick][202205][build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages (#3328) |
|
@saiarcot895 I saw you upgraded docker to 7.1.0 to fix this issue: sonic-net/sonic-buildimage#19181 Should we revert this PR? When I run sonic-utilities test, the env is installing requests=2.32.3 but current PR requires request<=2.32.0 so UT cannot run. |
|
@lizhijianrd I think it can be reverted, but as long as docker 7.1.0 is getting installed in the test environment. I don't know if that is the case here. |
…en urllib3 and requests packages (sonic-net#3328) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
…en urllib3 and requests packages (sonic-net#3328) (sonic-net#3337) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
…en urllib3 and requests packages (sonic-net#3328) * [build] Fix base OS compilation issue caused by incompatibility between urllib3 and requests packages * [pipeline] Pin request package to v2.31.0
What I did
Fix SONiC image compilation issue:
How I did it
Pin request version <=
<=2.31.0.How to verify it
Run SONiC image compilation.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)