Skip to content

Upgrade docker-py to 7.1.0#19181

Merged
lguohan merged 1 commit intosonic-net:masterfrom
saiarcot895:upgrade-docker-py
Jun 4, 2024
Merged

Upgrade docker-py to 7.1.0#19181
lguohan merged 1 commit intosonic-net:masterfrom
saiarcot895:upgrade-docker-py

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Jun 3, 2024

Why I did it

This version of docker-py has the fix for the issue caused by requests 2.32, and has the added benefit of upgrading to the latest version of docker-py.

Work item tracking
  • Microsoft ADO (number only): 28314184

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

# docker Python API package is needed by Ansible docker module as well as some SONiC applications
sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install 'docker==6.1.1'
sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install 'docker==7.1.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required in other branches?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is needed on 202311 and 202305 as well (at minimum). However, looking in the build pipelines, I see that the build for both is passing (without any version pinning). If it is actually needed, I can add the labels here.

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Jun 4, 2024

/azpw ms_conflict

@anamehra
Copy link
Copy Markdown
Contributor

Hi @saiarcot895 , any update on double commit? I see requests label added last week but no commit yet. This is affecting builds on 202311. Thanks

@saiarcot895
Copy link
Copy Markdown
Contributor Author

@anamehra I had added but then removed the requests labels, because the build pipelines for 202305 and 202311 were passing. However, I now see that in the pipelines I was looking at, Python 2 and Python 3 package versions are pinned for non-master branches, which means it would not run into this error.

I've added the request labels for 202305 and 202311.

@krismarvell
Copy link
Copy Markdown
Contributor

HI @saiarcot895 I am running into this error for innovium build in 202211 branch. Can we backport this into 202211 as well?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 27, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 27, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202211: #20359

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202305: #20360

mssonicbld pushed a commit that referenced this pull request Sep 27, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
andrewsapronov pushed a commit to netbergtw/sonic-buildimage that referenced this pull request Nov 6, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
bradh352 pushed a commit to bradh352/sonic-buildimage that referenced this pull request Dec 3, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@liushilongbuaa
Copy link
Copy Markdown
Contributor

Cherry-pick PR to 202211: #20359

Builb failed.

Writing /usr/local/lib/python2.7/dist-packages/scapy-2.2.0_dev.egg-info
Cloning into 'sflowtool'...
configure.ac:4: error: Autoconf version 2.71 or higher is required
configure.ac:4: the top level
autom4te: /usr/bin/m4 failed with exit status: 63
aclocal: error: echo failed with exit status: 63
autoreconf: aclocal failed with exit status: 63
The command '/bin/sh -c rm -rf /debs     && apt-get -y autoclean     && apt-get -y autoremove     && rm -rf /var/lib/apt/lists/*     && wget --https-only https://bootstrap.pypa.io/pip/2.7/get-pip.py     && python get-pip.py     && rm -f get-pip.py     && pip install setuptools     && pip install supervisor     && pip install ipython==5.4.1     && git clone https://github.com/p4lang/scapy-vxlan.git     && cd scapy-vxlan     && python setup.py install     && cd ..     && rm -fr scapy-vxlan     && git clone https://github.com/sflow/sflowtool     && cd sflowtool     && ./boot.sh     && ./configure     && make     && make install     && cd  ..     && rm -fr sflowtool     && git clone https://github.com/dyninc/OpenBFDD.git     && cd OpenBFDD     && ./autogen.sh     && ./configure     && make     && make install     && cd  ..     && rm -fr OpenBFDD     && wget https://github.com/nanomsg/nanomsg/archive/1.0.0.tar.gz     && tar xvfz 1.0.0.tar.gz     && cd nanomsg-1.0.0        && mkdir -p build          && cd build                && cmake ..                && make install            && ldconfig                && cd ../..                && rm -fr nanomsg-1.0.0     && rm -f 1.0.0.tar.gz      && pip install cffi        && pip install nnpy        && pip install dpkt        && pip install ipaddress     && pip install pysubnettree     && pip install paramiko     && pip install flask       && pip install exabgp==3.4.17    && pip install pyaml       && pip install pybrctl pyro4 rpyc yabgp     && pip install unittest-xml-reporting     && pip install pyrasite     && pip install retrying     && mkdir -p /opt           && cd /opt                 && wget https://raw.githubusercontent.com/p4lang/ptf/master/ptf_nn/ptf_nn_agent.py' returned a non-zero code: 63
[  FAIL LOG END  ] [ target/docker-ptf.gz ]

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 9, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #21092

mssonicbld pushed a commit that referenced this pull request Dec 9, 2024
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants