[202012][show_bfd] add local discriminator in show bfd command#2616
Merged
siqbal1986 merged 3 commits intosonic-net:202012from Jan 25, 2023
Merged
[202012][show_bfd] add local discriminator in show bfd command#2616siqbal1986 merged 3 commits intosonic-net:202012from
siqbal1986 merged 3 commits intosonic-net:202012from
Conversation
add local discriminator in : show bfd summary show bfd peer
This was referenced Jan 24, 2023
siqbal1986
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
the pull request sonic-net/sonic-swss#2587 added local_discriminator to state_db
In this pull request, local discriminator is added in the output of the following show commands :
the upcoming BFD debug CLI needs the local discriminator to specify BFD session.
How I did it
in show/main.py show bfd cli, read state db and show the value if there is local_discriminator field, and show "NA" if the field does not exist (backward compatible).
How to verify it
updated the test/show_bfd_test.py to test the local_discriminator field and show bfd cli output.
and also did manual test in a testbed (with modified bfdorch wich sonic-net/sonic-swss/pull/2587 diff ):
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)