[orchagent]:add local_discriminator for BFD session to state_db#2587
Merged
siqbal1986 merged 1 commit intosonic-net:202012from Jan 11, 2023
Merged
Conversation
Add local_discriminator to state DB for 'show bfd' cmd to show local discriminator. User can use this local discriminator to specify a BFD session when using BFD debugging command or checking syslog.
|
|
Collaborator
|
@baorliu , please sign CLA. Can you also raise the PR to master with a VS test? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
siqbal1986
approved these changes
Jan 11, 2023
This was referenced Jan 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add local_discriminator to state DB when bfdorch create_bfd_session.
Why I did it
For upcoming BFD debugging related CLI, user need to use local_discriminator to specify which BFD session they want to debug. current show bfd CLI does not have this information (the local_discriminator is not in state DB).
Also, this is local_discriminator printed into syslog, user may want to correlate this local_discriminator to BFD session.
How I verified it
with modified code, and modified show bfd python script, the local discriminator can be shown in 'show bfd' cmd:
(show "NA" if there is no local_discriminator in state DB.)
modification for "show bfd" script will be committed separately in another PR.
Details if related
Example of BFD session entry in state DB with local_discriminator: