Skip to content

Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prgeor merged 2 commits into from
Dec 5, 2022
Merged

Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f7386
EEPROM CLI support to dump output from TRANSCEIVER_DOM_THRESHOLD table
mihirpat1 Dec 2, 2022
61ee516
Resolved test failures
mihirpat1 Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/sfpshow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ class SFPShow(object):
if dump_dom:
sfp_type = sfp_info_dict['type']
dom_info_dict = state_db.get_all(state_db.STATE_DB, 'TRANSCEIVER_DOM_SENSOR|{}'.format(interface_name))
dom_info_dict.update(state_db.get_all(state_db.STATE_DB, 'TRANSCEIVER_DOM_THRESHOLD|{}'.format(interface_name)))
Copy link

@shyam77git shyam77git Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihirpat1 : Please validate, add UT outcome of following CLIs:

specific port (optics EEPROM/DOM)

  1. show int trans eeprom Ethernet<> -n asic<>
  2. show int trans eeprom --dom Ethernet<> -n asic<>

all ports where optics inserted in LC/Fixed-chassis
3) show int trans eeprom
4)show int trans eeprom --dom

Copy link
Contributor Author

@mihirpat1 mihirpat1 Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now added the multi asic UT enclosure to sonic-net/sonic-platform-daemons#320.
https://github.com/sonic-net/sonic-platform-daemons/files/10157449/Unit-test_400ZR_Multiasic.txt

dom_output = self.convert_dom_to_output_string(sfp_type, dom_info_dict)
output += dom_output
else:
Expand Down
4 changes: 3 additions & 1 deletion tests/mock_tables/asic0/state_db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
"tx1power": "N/A",
"tx2power": "N/A",
"tx3power": "N/A",
"tx4power": "N/A",
"tx4power": "N/A"
},
"TRANSCEIVER_DOM_THRESHOLD|Ethernet0": {
"rxpowerhighalarm": "3.4001",
"rxpowerhighwarning": "2.4000",
"rxpowerlowalarm": "-13.5067",
Expand Down
4 changes: 3 additions & 1 deletion tests/mock_tables/asic1/state_db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
"tx1power": "N/A",
"tx2power": "N/A",
"tx3power": "N/A",
"tx4power": "N/A",
"tx4power": "N/A"
},
"TRANSCEIVER_DOM_THRESHOLD|Ethernet64": {
"rxpowerhighalarm": "3.4001",
"rxpowerhighwarning": "2.4000",
"rxpowerlowalarm": "-13.5067",
Expand Down
8 changes: 6 additions & 2 deletions tests/mock_tables/state_db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@
"tx1power": "N/A",
"tx2power": "N/A",
"tx3power": "N/A",
"tx4power": "N/A",
"tx4power": "N/A"
},
"TRANSCEIVER_DOM_THRESHOLD|Ethernet0": {
"rxpowerhighalarm": "3.4001",
"rxpowerhighwarning": "2.4000",
"rxpowerlowalarm": "-13.5067",
Expand Down Expand Up @@ -111,7 +113,9 @@
"tx5power": "1.175",
"tx6power": "1.175",
"tx7power": "1.175",
"tx8power": "1.175",
"tx8power": "1.175"
},
"TRANSCEIVER_DOM_THRESHOLD|Ethernet8": {
"rxpowerhighalarm": "6.9999",
"rxpowerhighwarning": "4.9999",
"rxpowerlowalarm": "-11.9044",
Expand Down