Create TRANSCEIVER_DOM_THRESHOLD table in state DB#320
Create TRANSCEIVER_DOM_THRESHOLD table in state DB#320prgeor merged 3 commits intosonic-net:masterfrom
Conversation
|
@mihirpat1 |
The current PR is only for supporting the state DB related changes. I have filed sonic-net/sonic-buildimage#12911 to track the CLI support for the same. |
|
I see the o/p of "sfpshow eeprom -d -p port_name" have "ModuleThresholdValues:" and looks incomplete. |
Yes, the corresponding changes will be done with the issue mentioned above |
the show int trans CLI o/p will have the Module threshold values right? |
Need access since part of SONiC teamI have now raised sonic-net/sonic-utilities#2535 to ensure that the CLI output remains unchanged with the current changes. We plan to commit both this and sonic-net/sonic-utilities#2535 at the same time to avoid running into dependency issues. |
Signed-off-by: Mihir Patel <[email protected]>
Signed-off-by: Mihir Patel <[email protected]>
Signed-off-by: Mihir Patel <[email protected]>
f9f2a02 to
1265a6c
Compare
|
@mihirpat1 |
I have added the requested UT enclosure to this PR now. |
* Create TRANSCEIVER_DOM_THRESHOLD table in state DB Signed-off-by: Mihir Patel <[email protected]> * Removed debug statement Signed-off-by: Mihir Patel <[email protected]> * Fixed test failure Signed-off-by: Mihir Patel <[email protected]> Signed-off-by: Mihir Patel <[email protected]>
* Create TRANSCEIVER_DOM_THRESHOLD table in state DB Signed-off-by: Mihir Patel <[email protected]> * Removed debug statement Signed-off-by: Mihir Patel <[email protected]> * Fixed test failure Signed-off-by: Mihir Patel <[email protected]> Signed-off-by: Mihir Patel <[email protected]>
- Description For cmis cable, tx power and rx power is not rounding as other eeprom fields - Motivation and Context Fix issue: rounding float value for txpower and rxpower - How Has This Been Tested? Manual test
Description
This PR is adding the required changes for creating a table for DOM threshold in state DB. Please refer to CMIS_and_C-CMIS_support_for_ZR.md document for field definitions for TRANSCEIVER_DOM_THRESHOLD.
Overall, TRANSCEIVER_DOM_SENSOR DB table currently comprised of fields for TRANSCEIVER_DOM_SENSOR as well as TRANSCEIVER_DOM_THRESHOLD. With the current PR, a separate entry in state DB has now been created for TRANSCEIVER_DOM_THRESHOLD related fields.
The new command to display the threshold relevant fields will be done separately and is currently being tracked using sonic-net/sonic-buildimage#12911.
PR sonic-net/sonic-utilities#2535 has now been created to ensure that the output from "show interface transceiver eeprom <port> -d" remains unchanged after the current PR is merged. Both the current PR and sonic-net/sonic-utilities#2535 needs to be merged at the same time to avoid running into issues since they are dependent.
Motivation and Context
How Has This Been Tested?
400ZR related testing
Unit-test_400ZR.txt
100G and 10G related testing
Unit-test_100G_10G.txt
Transceiver info o/p
Unit-test_transceiver_info.txt
400ZR UT for multi-asic switch
Unit-test_400ZR_Multiasic.txt
Additional Information (Optional)
Signed-off-by: Mihir Patel [email protected]