Skip to content

[GCU] Enabling AddRack and adding RemoveRack tests#2143

Merged
ghooo merged 1 commit intosonic-net:masterfrom
ghooo:gcu_rack
Apr 29, 2022
Merged

[GCU] Enabling AddRack and adding RemoveRack tests#2143
ghooo merged 1 commit intosonic-net:masterfrom
ghooo:gcu_rack

Conversation

@ghooo
Copy link
Contributor

@ghooo ghooo commented Apr 27, 2022

What I did

Fixes #2051

RemoveRack/AddRack is confirmed to be working correctly by Renuka. Check sonic-net/sonic-mgmt#5254

How I did it

  • Enabled ADD_RACK test
  • Created REMOVE_RACK test using opposite data to ADD_RACK, verified the generated steps manually.

How to verify it

UnitTest and the KVM test by Renuka.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@ghooo ghooo requested review from qiluo-msft and wen587 April 28, 2022 23:09
@qiluo-msft
Copy link
Contributor

#2034 is still open. Does this PR depend on 2034?

@ghooo
Copy link
Contributor Author

ghooo commented Apr 29, 2022

#2034 is still open. Does this PR depend on 2034?

2034 only blocks testing CABLE_LENGTH, will handle it separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GCU] During RemoveRack, interfaces needs to be removed last

2 participants