AddRack: Skip multi asic & remove hack#5254
Merged
wangxin merged 5 commits intosonic-net:masterfrom Mar 7, 2022
Merged
Conversation
|
This pull request introduces 1 alert when merging b48b186 into bba35fa - view on LGTM.com new alerts:
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghooo
approved these changes
Mar 3, 2022
renukamanavalan
changed the title
wangxin
approved these changes
Mar 7, 2022
ghooo
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 29, 2022
#### What I did Fixes #2051 RemoveRack/AddRack is confirmed to be working correctly by Renuka. Check sonic-net/sonic-mgmt#5254 #### How I did it - Enabled ADD_RACK test - Created REMOVE_RACK test using opposite data to ADD_RACK, verified the generated steps manually. #### How to verify it UnitTest and the KVM test by Renuka. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
#### What I did Fixes #2051 RemoveRack/AddRack is confirmed to be working correctly by Renuka. Check sonic-net/sonic-mgmt#5254 #### How I did it - Enabled ADD_RACK test - Created REMOVE_RACK test using opposite data to ADD_RACK, verified the generated steps manually. #### How to verify it UnitTest and the KVM test by Renuka. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Generic Patch updater does not support multi asic yet.
Generic Patch Updater has fixed reported issues, hence remove the hack mode.
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failed in unsupported platform. No more hack mode in testing.
How did you do it?
Skip it explicitly. Remove hackmode flag set to True
How did you verify/test it?
Ran the test in master 3 times successfully.
master.76122-5e1acf022
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation