Skip to content

[config/show] add support for vlan configuration#151

Merged
lguohan merged 1 commit intosonic-net:masterfrom
ishidawataru:vlan
Dec 6, 2017
Merged

[config/show] add support for vlan configuration#151
lguohan merged 1 commit intosonic-net:masterfrom
ishidawataru:vlan

Conversation

@ishidawataru
Copy link
Contributor

@ishidawataru ishidawataru commented Nov 17, 2017

sonic-net/sonic-py-swsssdk#22 and sonic-net/sonic-py-swsssdk#23 need to be get merged before this PR.

$ config vlan add 1000
$ config vlan member add 1000 Ethernet1
$ config vlan member add 1000 Ethernet9_1 -u
$ config vlan add 2000
$ config vlan member add 2000 Ethernet1
$ config vlan member add 2000 Ethernet9_2 -u

$ show vlan config
Name        VID  Member       Mode
--------  -----  -----------  --------
Vlan1000   1000  Ethernet1    tagged
                 Ethernet9_1  untagged
Vlan2000   2000  Ethernet1    tagged
                 Ethernet9_2  untagged

$ config vlan member del 1000 Ethernet1
$ config vlan member del 2000 Ethernet1

$ show vlan config
Name        VID  Member       Mode
--------  -----  -----------  --------
Vlan1000   1000  Ethernet9_1  untagged
Vlan2000   2000  Ethernet9_2  untagged

$ config vlan del 1000
$ config vlan del 2000

$ show vlan config
Name    VID    Member    Mode
------  -----  --------  ------

@lguohan
Copy link
Contributor

lguohan commented Dec 5, 2017

both swsssdk PR has been merge, can you help to resolve the conflict?

@ishidawataru
Copy link
Contributor Author

@lguohan done.

config/main.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to delete vlan members before deleting the vlan itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. fixed.

$ config vlan add 1000
$ config vlan member add 1000 Ethernet1
$ config vlan member add 1000 Ethernet9_1 -u
$ config vlan add 2000
$ config vlan member add 2000 Ethernet1
$ config vlan member add 2000 Ethernet9_2 -u

$ show vlan config
Name        VID  Member       Mode
--------  -----  -----------  --------
Vlan1000   1000  Ethernet1    tagged
                 Ethernet9_1  untagged
Vlan2000   2000  Ethernet1    tagged
                 Ethernet9_2  untagged

$ config vlan member del 1000 Ethernet1
$ config vlan member del 2000 Ethernet

$ show vlan config
Name        VID  Member       Mode
--------  -----  -----------  --------
Vlan1000   1000  Ethernet9_1  untagged
Vlan2000   2000  Ethernet9_2  untagged

$ config vlan del 1000
$ config vlan del 2000

$ show vlan config
Name    VID    Member    Mode
------  -----  --------  ------

Signed-off-by: Wataru Ishida <[email protected]>
@lguohan lguohan merged commit b074868 into sonic-net:master Dec 6, 2017
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
Add GitHub pull request template
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
* [sonic_y_cable] add check_mux_direction api for y_cable

Summary:
This PR provides the support for checking the mux_direction on the y_cable by checking the mux_direction register

Approach
added the changes in y_cable.py with register specification for check_mux_direction

What is the motivation for this PR?
check_mux_direction is required for y_cable_utilities to replace the active_linked_tor_side -> check_mux_direction as agreed as a part of design

Signed-off-by: vaibhav-dahiya <[email protected]>
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-utilities that referenced this pull request Mar 31, 2025
sonic-net#151)

```<br>* 93d21bc1 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-03-13) [Sonic Automation]
* 04bc01d - (origin/202411) [Techsupport]Add show route-map command to frr dumps in techsupport (sonic-net#3803) (2025-03-13) [mssonicbld]
* 7a3f4ad - Fix the interface name length validation for subinterface (sonic-net#3799) (2025-03-11) [mssonicbld]
* 357f95d - enable pfcwd for backplane ports (sonic-net#3796) (2025-03-07) [mssonicbld]
* 7f316e7 - revert YANG check in db_migrator (sonic-net#3794) (2025-03-06) [mssonicbld]
* c01a4f5 - Add namespace support for show interface neighbor expected (sonic-net#3790) (2025-03-03) [mssonicbld]
* 17a7b18 - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2025-02-25) [mssonicbld]
* 5cc1012 - [202411][FC] remove FC delay field (sonic-net#3768) (2025-02-21) [Stepan Blyshchak]
* 8ceba38 - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld]
* 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld]
* bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants