[configdb] fix bug of leaving unwanted columns in a hash#23
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 5, 2017
Merged
[configdb] fix bug of leaving unwanted columns in a hash#23lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Current implementation doesn't remove unwanted columes with set_entry
like below.
>>> set_entry('table', 'key', {'key1': 'value1', 'key2': 'value2'})
>>> set_entry('table', 'key', {'key1': 'value3'})
>>> get_entry('table', 'key')
{'key1': 'value3', 'key2': 'value2'}
This commit fix this bug.
Signed-off-by: Wataru Ishida <[email protected]>
Contributor
Author
Contributor
|
@taoyl-ms please check. |
Contributor
|
set api usually does @ishidawataru says, we need to add a mod_entry API to explicit modify the field. |
lguohan
approved these changes
Dec 5, 2017
praveen-li
pushed a commit
to praveen-li/sonic-py-swsssdk
that referenced
this pull request
May 4, 2021
* msft_github/master: [configdb]: Addopt get_table method to work with python3. (sonic-net#26) [configdb]: add mod_entry, rename set_config to mod_config (sonic-net#25) [configdb] fix bug of leaving unwanted columns in a hash (sonic-net#23) Revert "Add support to remove the key of table entry (sonic-net#15)" (sonic-net#24) Add support to remove the key of table entry (sonic-net#15) [configdb] support redis connecting methods other than TCP (sonic-net#22) [interface]: Extend the max data wait time to 60s (sonic-net#21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't remove unwanted columes with set_entry
like below.
This commit fix this bug.
Signed-off-by: Wataru Ishida [email protected]