Skip to content

[CLI][show][platform] Added ASIC count in the output. (#1185)#1227

Merged
abdosi merged 1 commit intosonic-net:201911from
smaheshm:201911
Nov 13, 2020
Merged

[CLI][show][platform] Added ASIC count in the output. (#1185)#1227
abdosi merged 1 commit intosonic-net:201911from
smaheshm:201911

Conversation

@smaheshm
Copy link
Copy Markdown
Contributor

- What I did

Added platform ASIC count output to platform summary. Also added option for JSON output.
Note: This is a merge from "master".

- How I did it

Added ASIC count in hardware info.

- How to verify it

Manual CLI verification.

- Previous command output (if the output of a command-line utility has changed)

admin@str-s6000-acs-9:~$ show platform summary 
Platform: x86_64-dell_s6000_s1220-r0
HwSKU: Force10-S6000
ASIC: broadcom

- New command output (if the output of a command-line utility has changed)

admin@str-s6000-acs-9:~$ show platform summary 
Platform: x86_64-dell_s6000_s1220-r0
HwSKU: Force10-S6000
ASIC: broadcom
ASIC Count: 1
admin@str-s6000-acs-9:~$ show platform summary --json
{
  "asic_count": 1, 
  "asic_type": "broadcom", 
  "hwsku": "Force10-S6000", 
  "platform": "x86_64-dell_s6000_s1220-r0"
}

admin@str-nswitch-acs-2:/usr/lib/python2.7/dist-packages/utilities_common$ show platform summary
Platform: x86_64-nswitch-r0      
HwSKU: nswitch                          
ASIC: broadcom
ASIC Count: 6                              
admin@str-n3164-acs-2:/usr/lib/python2.7/dist-packages/utilities_common$ show platform summary --json
{                    
  "asic_count": 6,
  "asic_type": "broadcom",               
  "hwsku": "nswitch",
  "platform": "x86_64-nswitch-r0"
}  

@smaheshm smaheshm requested a review from abdosi November 10, 2020 21:34
@smaheshm
Copy link
Copy Markdown
Contributor Author

retest this please

@smaheshm
Copy link
Copy Markdown
Contributor Author

@abdosi Is the failure in pytest expected?

@abdosi abdosi merged commit d683bb4 into sonic-net:201911 Nov 13, 2020
Copy link
Copy Markdown
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
c0df635 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224) (sonic-net#1237)
d683bb4 [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) (sonic-net#1227)
4585be1 [show] Fix 'show int neigh expected' (sonic-net#1189)
29e4469 [201911][fwutil]: Use logger from sonic-py-common (sonic-net#1190)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants