Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table#1224
Merged
judyjoseph merged 3 commits intosonic-net:masterfrom Nov 13, 2020
Merged
Conversation
bgp sessions to a new table BGP_INTERNAL_TABLE
Contributor
|
@judyjoseph Should we remove the internal sessions from |
Contributor
Author
Yes Pavel, we don't display the internal bgp sessions by default, I have added the o/p of "show ip bgp summary" in the PR description. It will be shown only if user gives the option "-d all" explicitly as the command below. |
pavel-shirshov
previously approved these changes
Nov 9, 2020
Contributor
Author
|
@pavel-shirshov @arlakshm, please take a look. I wanted to update the unit tests as well.. |
pavel-shirshov
approved these changes
Nov 12, 2020
judyjoseph
added a commit
to judyjoseph/sonic-utilities
that referenced
this pull request
Nov 13, 2020
abdosi
pushed a commit
that referenced
this pull request
Nov 14, 2020
Contributor
|
@judyjoseph - is this one still needed to be cherry-picked to 201911? @arlakshm - please review/approve? Thanks. |
Contributor
|
@rlhui already in 201911 via direct pr for 201911 |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
c0df635 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224) (sonic-net#1237) d683bb4 [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) (sonic-net#1227) 4585be1 [show] Fix 'show int neigh expected' (sonic-net#1189) 29e4469 [201911][fwutil]: Use logger from sonic-py-common (sonic-net#1190) Signed-off-by: Abhishek Dosi <[email protected]>
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Jul 18, 2022
Reintroduce the msft templates for multi-asic(3164) after the following sonic public PR's ( for internal BGP neighbors) are available in internal-201911 branch. sonic-net#5520 sonic-net#5760 sonic-net/sonic-swss-common#389 sonic-net/sonic-utilities#1224 How did I verify ----------------- 1. Verified the external and internal BGP sessions are up, shown correctly in "show ip bgp summary -d all" and show ip interface commands. 2. Ran related 3164 tests to make sure it is passing. bgp/test_bgp_fact.py::test_bgp_facts[0-0] PASSED [ 16%] bgp/test_bgp_fact.py::test_bgp_facts[0-1] PASSED [ 33%] bgp/test_bgp_fact.py::test_bgp_facts[0-2] PASSED [ 50%] bgp/test_bgp_fact.py::test_bgp_facts[0-3] PASSED [ 66%] bgp/test_bgp_fact.py::test_bgp_facts[0-4] PASSED [ 83%] bgp/test_bgp_fact.py::test_bgp_facts[0-5] PASSED [100%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[0] PASSED [ 57%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[1] PASSED [ 63%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[2] SKIPPED [ 68%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[3] SKIPPED [ 73%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[4] SKIPPED [ 78%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[5] SKIPPED [ 84%]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Updates to bgp config and show commands with the movement of internal bgp sessions to a new table BGP_INTERNAL_NEIGHBOR table.
With the introduction of BGP_INERNAL_NEIGHBOR table, the user cannot start/stop/remove internal neighbors which I feel is not needed as these internal bgp sessions which are supposed to be UP allways.
- How I did it
Updated the show/bgp util so that it gets the internal bgp sessions from BGP_INTERNAL_NEIGHBOR table.
Removed the API's to get the local_as in config/bgp which is not required now.
- How to verify it
Made sure that the output remain same with the new internal bgp neighbor table.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)