Closed
Conversation
Author
Contributor
|
retest this please |
Contributor
|
Closing as a duplicate of #1126, in which the new import is added in alphabetical order, whereas in this PR it is not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced the issue when call
show ip interfaceson the latest SONiC image(03f82a0):In this PR
netaddrwas removed, but we need it to convert subnet mask to cidr here- What I did
Fix
NameError: global name 'netaddr' is not defined- How I did it
import netaddr module
- How to verify it
show ip interfaces- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)