[show] Add missing import to fix show ip interfaces#1126
Merged
jleveque merged 1 commit intosonic-net:masterfrom Sep 23, 2020
Merged
[show] Add missing import to fix show ip interfaces#1126jleveque merged 1 commit intosonic-net:masterfrom
show ip interfaces#1126jleveque merged 1 commit intosonic-net:masterfrom
Conversation
Add the missing import of `netaddr` for `show ip interfaces`. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
3ca202a to
afb7f61
Compare
Contributor
|
Retest this please |
4 similar comments
Contributor
|
Retest this please |
Contributor
|
Retest this please |
Contributor
|
Retest this please |
Contributor
|
Retest this please |
Contributor
|
same as #1129 |
show ip interfaces
Closed
Contributor
|
@neethajohn: Thanks for pointing out that duplicate PR. I just closed #1129 as a duplicate of this PR, because 1.) This PR was opened first, and 2.) In this PR, the import is added in alphabetical order. We will merged this PR. |
neethajohn
approved these changes
Sep 23, 2020
jleveque
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing import of
netaddrforshow ip interfaces.Signed-off-by: Longxiang Lyu lolv@microsoft.com
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)