Skip to content

Backport ACL/MIRROR features to 201811 branch#965

Merged
lguohan merged 6 commits intosonic-net:201811from
stcheng:201811
Jul 2, 2019
Merged

Backport ACL/MIRROR features to 201811 branch#965
lguohan merged 6 commits intosonic-net:201811from
stcheng:201811

Conversation

@stcheng
Copy link
Copy Markdown
Contributor

@stcheng stcheng commented Jul 2, 2019

No description provided.

Shuotian Cheng added 6 commits July 1, 2019 10:07
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
…et#825)

Enable both IPv4 and IPv6 source and destination IP match and
mirror functionality in SONiC.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Support the following matches:
SAI_ACL_TABLE_ATTR_FIELD_ICMP_TYPE
SAI_ACL_TABLE_ATTR_FIELD_ICMP_CODE
SAI_ACL_TABLE_ATTR_FIELD_ICMPV6_TYPE
SAI_ACL_TABLE_ATTR_FIELD_ICMPV6_CODE

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
…et#889)

Now that we could create a policer for the mirror session to
throttle the mirroring traffic.

configuration:

POLICER|NAME:
 meter_type:packets|bytes
 mode:sr_tcm|tr_tcm|storm_control
 cir|DIGITS
 cbs|DIGITS
 pir|DIGITS
 pbs|DIGITS
 corlor_source:aware|blind
 red_action:drop
 yellow_action:drop
 green_action:drop

MIRROR_SESSION|NAME:
 policer:policer_name

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Due to the change

c033b23
Fix MIRROR_SESSION table macro name (sonic-net#802)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@lguohan lguohan merged commit 53b731c into sonic-net:201811 Jul 2, 2019
@stcheng stcheng deleted the 201811 branch July 3, 2019 17:40
@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 3, 2019

#906 is missing; it is cherry-picked later

@jangidrk
Copy link
Copy Markdown
Contributor

Hi,
could you help in explaining if Warm-reboot for Policer is supported and how?
create_policer( &policer_id, gSwitchId, (uint32_t)attrs.size(), attrs.data())
there could be two differnet policer_id with same attribute.

@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 10, 2019

@jangidrk yes; but that's fine; we will assign back the policers based on which other objects they are attached to; if they are two stand-alone policers with purely same attributes; they will be assigned back randomly after warm reboot.

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…c-net#965)

If FEATURE table did not exist,` config load/reload/reload_minigraph` commands would crash similar to the following:

```
Executing reset-failed of service nat...
Executing reset-failed of service sflow...
Traceback (most recent call last):
  File "/usr/bin/config", line 12, in <module>
    sys.exit(config())
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/config/main.py", line 862, in reload
    _restart_services()
  File "/usr/lib/python2.7/dist-packages/config/main.py", line 585, in _restart_services
    disable_services = _get_disabled_services_list()
  File "/usr/lib/python2.7/dist-packages/config/main.py", line 518, in _get_disabled_services_list
    if status == "disabled":
UnboundLocalError: local variable 'status' referenced before assignment
```
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants