[aclorch]: Add MIRRORv6 support for ACL table by stcheng · Pull Request #825 · sonic-net/sonic-swss

stcheng · 2019-03-29T19:55:47Z

Enable both IPv4 and IPv6 source and destination IP match and
mirror functionality in SONiC.

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

orchagent/aclorch.cpp

qiluo-msft · 2019-03-30T00:00:12Z

tests/test_mirror_ipv6.py

+        assert status == True
+        for fv in fvs:
+            if fv[0] == "SAI_ACL_ENTRY_ATTR_FIELD_SRC_IPV6":
+                assert fv[1] == "2777::&mask:ffff:ffff:ffff:ffff::"


'&mask' is weird. Could you explain?

this is the serialization done by sairedis library; swss does not have the control here.

orchagent/aclorch.cpp

stcheng · 2019-04-23T00:38:26Z

Updated with new design

stcheng · 2019-04-23T01:27:09Z

TODO:

will update the unit test both both Broadcom and Mellanox scenarios
will remove deprecated code in swss for virtual switch platform

DONE

orchagent/aclorch.cpp

lguohan · 2019-04-24T08:14:49Z

orchagent/aclorch.cpp

+                break;
+        }
+    }
+    m_switchTable.set("switch", fvVector);


this code really need to go to syncd code. We will address this in the next release.

sure i could add some todo to here

One issue about moving this to syncd right now is that we currently cannot guarantee the order of syncd and orchagent starting time. e.g. when orchagent starts and at that time syncd hasn't stored the capability information into the database, we will miss this part of the information.

orchagent/aclorch.cpp

Enable both IPv4 and IPv6 source and destination IP match and mirror functionality in SONiC. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

…et#825) Enable both IPv4 and IPv6 source and destination IP match and mirror functionality in SONiC. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

…ic-net#825) * [fwutil]: Use overlay driver when mounting next image filesystem. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Update command reference. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

When making build sairedis directory could be polluted by previous build which was configured without '--enable-syncd=no', and that created makefiles for previous build for example binary-syncd target, next when dh clean is executed for target binary-sairedis, it's executing existing configure with previous parameters by executing "./bin/bash ./config.status .recheck", this don't contain --enable-syncd=no, and this requires libsai to be present for configuration, this will cause configure to fail, but dh clean will ignore that error and continue next commands. Because of this, make distclean was not executed, and directory contains previous build artifacts like _pysairedis.la in pyext directory, which was from stretch build, and points to different python version 3.5 vs 3.7 on buster, and since _pysairedis.la exists, it's content are used to pass that python library to link stage of python build. To workaround this, we can export shell variable to disable libsai requirement, and distclean will succeed, but there still be left artifacts in syncd directory and others conditioned in Makefile.am Signed-off-by: kcudnik <kcudnik@gmail.com>

…et#825) Enable both IPv4 and IPv6 source and destination IP match and mirror functionality in SONiC. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* Use json.hpp from nlohmann-json-dev instead of local version This header file comes from an external package, and a very old version of the header file has been checked into this repo. This will cause problems for the upcoming Bookworm upgrade. Change references to the header file to use the Debian package nlohmann-json-dev, and remove json.hpp from this repo.

stcheng added the Enhancement ➕ label Mar 29, 2019

jleveque reviewed Mar 29, 2019

View reviewed changes