[MirrorOrch]: Init the next hop ip with 0 instead of default constructor#953
Merged
stcheng merged 1 commit intosonic-net:masterfrom Jun 27, 2019
RichardWu-Hebut:mirror_nexthop_issue
Merged
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor#953stcheng merged 1 commit intosonic-net:masterfrom RichardWu-Hebut:mirror_nexthop_issue
stcheng merged 1 commit intosonic-net:masterfrom
RichardWu-Hebut:mirror_nexthop_issue
Conversation
Otherwise, in the getgetNeighborInfo function, it will check whether
the nexthop is zero, but it will return false according to
IpAddress::isZero(), then it will try to query the
neighbor orch about this invalid ip address.
Signed-off-by: Richard Wu <wutong23@baidu.com>
Contributor
|
thanks for fixing this |
stcheng
approved these changes
Jun 27, 2019
Contributor
|
retest this please |
Contributor
|
yxieca
pushed a commit
that referenced
this pull request
Jul 19, 2019
…tor (#953) Otherwise, in the getgetNeighborInfo function, it will check whether the nexthop is zero, but it will return false according to IpAddress::isZero(), then it will try to query the neighbor orch about this invalid ip address. Signed-off-by: Richard Wu <wutong23@baidu.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Add a new Bootloader abstraction. This makes it easier to add bootloader specific behavior while keeping the main logic identical. It is also a step that will ease the introduction of secureboot which relies on bootloader specific behaviors. Shuffle code around to get rid of the hacky if/else all over the place. There are now 3 bootloader classes - AbootBootloader - GrubBootloader - UbootBootloader There was almost no logic change in any of the implementations. Only the AbootBootloader saw some small improvements. More will follow in subsequent changes.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
The import re line was removed from the file in sonic-net#953. However, it is still referenced in the update_sonic_environment() function. Adding it back.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Added support for ACL counters to Flex Counter Infrastructure.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…tor (sonic-net#953) Otherwise, in the getgetNeighborInfo function, it will check whether the nexthop is zero, but it will return false according to IpAddress::isZero(), then it will try to query the neighbor orch about this invalid ip address. Signed-off-by: Richard Wu <wutong23@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Wu wutong23@baidu.com
What I did
Why I did it
How I verified it
Details if related
In current implement， in the getgetNeighborInfo function, it will check whether the nexthop is zero, but it will return false according to IpAddress::isZero(), then it will try to query the neighbor orch about this invalid ip address.