[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953)

RichardWu-Hebut · stcheng · commit def7ad492ee5 · 2019-06-27T09:27:16.000-07:00
Otherwise, in the getgetNeighborInfo function, it will check whether
    the nexthop is zero, but it will return false according to
    IpAddress::isZero(), then it will try to query the
    neighbor orch about this invalid ip address.

Signed-off-by: Richard Wu &lt;wutong23@baidu.com&gt;
diff --git a/orchagent/mirrororch.cpp b/orchagent/mirrororch.cpp
@@ -786,7 +786,7 @@ void MirrorOrch::updateNextHop(const NextHopUpdate& update)
         }
         else
         {
-            session.nexthopInfo.nexthop = IpAddress();
+            session.nexthopInfo.nexthop = IpAddress(0);
         }
 
         // Resolve the neighbor of the new next hop

Original file line number	Diff line number	Diff line change
`@@ -786,7 +786,7 @@ void MirrorOrch::updateNextHop(const NextHopUpdate& update)`
`786`	`786`	`}`
`787`	`787`	`else`
`788`	`788`	`{`
`789`		`- session.nexthopInfo.nexthop = IpAddress();`
	`789`	`+ session.nexthopInfo.nexthop = IpAddress(0);`
`790`	`790`	`}`
`791`	`791`
`792`	`792`	`// Resolve the neighbor of the new next hop`