RouteSync::onMsg supports ipv6 route#78
Merged
stcheng merged 4 commits intosonic-net:masterfrom Sep 14, 2016
Merged
Conversation
qiluo-msft
force-pushed
the
qiluo/fpm-v6
branch
from
3a14b96 to
b61750f
Compare
fpmsyncd/routesync.cpp
Outdated
| /* Supports IPv4 address only for now */ | ||
| if (rtnl_route_get_family(route_obj) != AF_INET) | ||
| nl_addr2str(dip, destipprefix, MAX_ADDR_SIZE); | ||
| SWSS_LOG_DEBUG("destipprefix=%s\n", destipprefix); |
Contributor
There was a problem hiding this comment.
not sure we need this debug log, at minimum it needs more be descriptive, like receive new route message dest ip prefix %s
Contributor
|
🕐 |
fpmsyncd/routesync.cpp
Outdated
| __FUNCTION__, destipprefix, nl_object_get_type(obj)); | ||
| return; | ||
| SWSS_LOG_INFO("%s: Unknown route family support: %s (object: %s)\n", | ||
| __FUNCTION__, destipprefix, nl_object_get_type(obj)); |
Contributor
There was a problem hiding this comment.
FUNCTION is always logged in any SWSS_LOG_INFO, no need it here
| /* Supports IPv4 address only for now */ | ||
| if (rtnl_route_get_family(route_obj) != AF_INET) | ||
| nl_addr2str(dip, destipprefix, MAX_ADDR_SIZE); | ||
| SWSS_LOG_DEBUG("Receive new route message dest ip prefix: %s\n", destipprefix); |
Contributor
There was a problem hiding this comment.
adding nlmsg_type here to log more information
Contributor
|
🚢 waiting for resolving all comments and then merge |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
May 20, 2025
[202412][trim]: Add Packet Trimming to OA
liuh-80
pushed a commit
to liuh-80/sonic-swss
that referenced
this pull request
Aug 31, 2025
```<br>* 32da647 - (HEAD -> 202503) Merge branch '202412' of https://github.com/Azure/sonic-swss.msft into 202503 (2025-05-26) [Sonic Automation] * 06b16c3 - (base/202412) [fpmsyncd]Fixing blackhole route to publish protocol field to APPL_DB (sonic-net#83) (2025-05-23) [Sudharsan Dhamal Gopalarathnam] * b801f2d - [202412] [SRv6] add MySID counters support (sonic-net#82) (2025-05-19) [Yakiv Huryk] * a999b4d - Merge pull request sonic-net#81 from r12f/code-sync-202412 (2025-05-17) [Dashuai Zhang] |\ | failure_prs.log fd87e1f - Merge remote-tracking branch 'base/202411' into code-sync-202412 (2025-05-16) [r12f] |/| | failure_prs.log 623b018 - (origin/202411) [202411] Setting default nexthop weight to 1 in fpmsyncd (2025-05-15) [Kumaresh Perumal] | |\ | | failure_prs.log a99088e - Removed logging code. (2025-05-15) [Mahdi Ramezani] | | failure_prs.log 5cdc78e - Fixed a compile error. (2025-05-15) [Mahdi Ramezani] | | failure_prs.log a79b7e0 - Set default nexthop weight to 1. Added unit tests for 'getNextHopWt'. (2025-05-15) [Mahdi Ramezani] | |/ * | 2a0856b - Merge pull request sonic-net#78 from nazariig/202412-trim-azure (2025-05-14) [Nazarii Hnydyn] * | 2daf207 - Enable FDB learning event after all ports removed from default 1Q bridge (sonic-net#79) (2025-05-09) [mssonicbld] * | 3b70292 - Move timestamps out of counter table to avoid update too frequently (sonic-net#75) (2025-04-28) [mssonicbld] * | 3fa0d72 - Merge pull request sonic-net#74 from mssonicbld/sonicbld/202412-merge (2025-04-23) [mssonicbld] * | be436da - Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 (2025-04-23) [Sonic Automation] |/ * 79f04e3 - Initialize the last fec ber computed values if not found (sonic-net#3621) (2025-04-22) [mssonicbld]<br>```
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…ld process (sonic-net#78) * Config and build gtest * Treat googletest as git submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.