Skip to content

[action] [PR:3604] Initialize the last fec ber computed values if not found#3621

Merged
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/3604
Apr 22, 2025
Merged

[action] [PR:3604] Initialize the last fec ber computed values if not found#3621
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/3604

Conversation

@mssonicbld
Copy link
Collaborator

@mssonicbld mssonicbld commented Apr 22, 2025

What I did

SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last and SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last counter values could be NOT present in redis, so initialize these values to ZERO

Why I did it
To prevent following error seen during warm boot

root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:206: attempt to perform arithmetic on local 'fec_corr_bits_last' (a boolean value) script: cb98161ae9433f9bf8265cffd7d2eaaf6ac9282f, on @user_script:206.
root@sonic:/#

How I verified it
After fix the last computer FEC ber values are stored in redis DB

root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
1) "0.18"
2) "0.82"
3) "10"
4) "DONE"
root@str2-7050cx3-acs-14:/# redis-cli -n 2 hgetall "RATES:oid:0x100000000000a"
 1) "SAI_PORT_STAT_IF_IN_UCAST_PKTS_last"
 2) "0"
 3) "SAI_PORT_STAT_IF_IN_NON_UCAST_PKTS_last"
 4) "0"
 5) "SAI_PORT_STAT_IF_OUT_UCAST_PKTS_last"
 6) "0"
 7) "SAI_PORT_STAT_IF_OUT_NON_UCAST_PKTS_last"
 8) "0"
 9) "SAI_PORT_STAT_IF_IN_OCTETS_last"
10) "0"
11) "SAI_PORT_STAT_IF_OUT_OCTETS_last"
12) "0"
13) "RX_BPS"
14) "0"
15) "RX_PPS"
16) "0"
17) "TX_BPS"
18) "0"
19) "TX_PPS"
20) "0"
21) "SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last"
22) "0"
23) "SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last"
24) "0"
25) "FEC_PRE_BER"
26) "0"
27) "FEC_POST_BER"
28) "0"
root@str2-7050cx3-acs-14:/#

Details if related

@mssonicbld
Initialize the last fec ber computed values if not found
e0d2bcf 
<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**

`SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last` and `SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last`  counter values could be NOT present in redis, so initialize these values to ZERO

**Why I did it**
To prevent following error seen during warm boot

```
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:206: attempt to perform arithmetic on local 'fec_corr_bits_last' (a boolean value) script: cb98161ae9433f9bf8265cffd7d2eaaf6ac9282f, on @user_script:206.
root@sonic:/#
```

**How I verified it**
After fix the last computer FEC ber values are stored in redis DB

```
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
1) "0.18"
2) "0.82"
3) "10"
4) "DONE"
root@str2-7050cx3-acs-14:/# redis-cli -n 2 hgetall "RATES:oid:0x100000000000a"
 1) "SAI_PORT_STAT_IF_IN_UCAST_PKTS_last"
 2) "0"
 3) "SAI_PORT_STAT_IF_IN_NON_UCAST_PKTS_last"
 4) "0"
 5) "SAI_PORT_STAT_IF_OUT_UCAST_PKTS_last"
 6) "0"
 7) "SAI_PORT_STAT_IF_OUT_NON_UCAST_PKTS_last"
 8) "0"
 9) "SAI_PORT_STAT_IF_IN_OCTETS_last"
10) "0"
11) "SAI_PORT_STAT_IF_OUT_OCTETS_last"
12) "0"
13) "RX_BPS"
14) "0"
15) "RX_PPS"
16) "0"
17) "TX_BPS"
18) "0"
19) "TX_PPS"
20) "0"
21) "SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last"
22) "0"
23) "SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last"
24) "0"
25) "FEC_PRE_BER"
26) "0"
27) "FEC_POST_BER"
28) "0"
root@str2-7050cx3-acs-14:/#
```

**Details if related**
@mssonicbld mssonicbld requested a review from prsunny as a code owner April 22, 2025 07:33
@mssonicbld
Copy link
Collaborator Author

mssonicbld commented Apr 22, 2025

Original PR: #3604

@mssonicbld mssonicbld mentioned this pull request Apr 22, 2025
Merged
@mssonicbld
Copy link
Collaborator Author

mssonicbld commented Apr 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 79f04e3 into sonic-net:202411 Apr 22, 2025
5 of 8 checks passed
DavidZagury pushed a commit to DavidZagury/sonic-swss that referenced this pull request Apr 28, 2025
@mssonicbld
Merge pull request sonic-net#74 from mssonicbld/sonicbld/202412-merge
3fa0d72 
```<br>* be436da - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 (2025-04-23) [Sonic Automation]
* 79f04e3 - (origin/202411) Initialize the last fec ber computed values if not found (sonic-net#3621) (2025-04-22) [mssonicbld]<br>```
bradh352 pushed a commit to bradh352/sonic-swss that referenced this pull request May 3, 2025
@mssonicbld @bradh352
Initialize the last fec ber computed values if not found (sonic-net#3621
e2838b9 
)

<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**

`SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last` and `SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last` counter values could be NOT present in redis, so initialize these values to ZERO

**Why I did it**
To prevent following error seen during warm boot

```
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:204: attempt to concatenate local 'fec_corr_bits_last' (a boolean value) script: b46cd0b446729aab6bbd20e0d4aa977e3da8f5f1, on @user_script:204.
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
(error) ERR user_script:206: attempt to perform arithmetic on local 'fec_corr_bits_last' (a boolean value) script: cb98161ae9433f9bf8265cffd7d2eaaf6ac9282f, on @user_script:206.
root@sonic:/#
```

**How I verified it**
After fix the last computer FEC ber values are stored in redis DB

```
root@sonic:/# redis-cli --eval ./usr/share/swss/port_rates.lua oid:0x100000000000a , 2 COUNTERS 10
1) "0.18"
2) "0.82"
3) "10"
4) "DONE"
root@str2-7050cx3-acs-14:/# redis-cli -n 2 hgetall "RATES:oid:0x100000000000a"
 1) "SAI_PORT_STAT_IF_IN_UCAST_PKTS_last"
 2) "0"
 3) "SAI_PORT_STAT_IF_IN_NON_UCAST_PKTS_last"
 4) "0"
 5) "SAI_PORT_STAT_IF_OUT_UCAST_PKTS_last"
 6) "0"
 7) "SAI_PORT_STAT_IF_OUT_NON_UCAST_PKTS_last"
 8) "0"
 9) "SAI_PORT_STAT_IF_IN_OCTETS_last"
10) "0"
11) "SAI_PORT_STAT_IF_OUT_OCTETS_last"
12) "0"
13) "RX_BPS"
14) "0"
15) "RX_PPS"
16) "0"
17) "TX_BPS"
18) "0"
19) "TX_PPS"
20) "0"
21) "SAI_PORT_STAT_IF_FEC_CORRECTED_BITS_last"
22) "0"
23) "SAI_PORT_STAT_IF_FEC_NOT_CORRECTABLE_FARMES_last"
24) "0"
25) "FEC_PRE_BER"
26) "0"
27) "FEC_POST_BER"
28) "0"
root@str2-7050cx3-acs-14:/#
```

**Details if related**
liuh-80 pushed a commit to liuh-80/sonic-swss that referenced this pull request Aug 31, 2025
@mssonicbld
Merge pull request sonic-net#85 from mssonicbld/sonicbld/202503-merge
d8c3d8c 
```<br>* 32da647 - (HEAD -> 202503) Merge branch '202412' of https://github.com/Azure/sonic-swss.msft into 202503 (2025-05-26) [Sonic Automation]
* 06b16c3 - (base/202412) [fpmsyncd]Fixing blackhole route to publish protocol field to APPL_DB (sonic-net#83) (2025-05-23) [Sudharsan Dhamal Gopalarathnam]
* b801f2d - [202412] [SRv6] add MySID counters support (sonic-net#82) (2025-05-19) [Yakiv Huryk]
* a999b4d - Merge pull request sonic-net#81 from r12f/code-sync-202412 (2025-05-17) [Dashuai Zhang]
|\ 
| failure_prs.log fd87e1f - Merge remote-tracking branch 'base/202411' into code-sync-202412 (2025-05-16) [r12f]
|/| 
| failure_prs.log 623b018 - (origin/202411) [202411] Setting default nexthop weight to 1 in fpmsyncd (2025-05-15) [Kumaresh Perumal]
| |\ 
| | failure_prs.log a99088e - Removed logging code. (2025-05-15) [Mahdi Ramezani]
| | failure_prs.log 5cdc78e - Fixed a compile error. (2025-05-15) [Mahdi Ramezani]
| | failure_prs.log a79b7e0 - Set default nexthop weight to 1. Added unit tests for 'getNextHopWt'. (2025-05-15) [Mahdi Ramezani]
| |/ 
* | 2a0856b - Merge pull request sonic-net#78 from nazariig/202412-trim-azure (2025-05-14) [Nazarii Hnydyn]
* | 2daf207 - Enable FDB learning event after all ports removed from default 1Q bridge (sonic-net#79) (2025-05-09) [mssonicbld]
* | 3b70292 - Move timestamps out of counter table to avoid update too frequently (sonic-net#75) (2025-04-28) [mssonicbld]
* | 3fa0d72 - Merge pull request sonic-net#74 from mssonicbld/sonicbld/202412-merge (2025-04-23) [mssonicbld]
* | be436da - Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 (2025-04-23) [Sonic Automation]
|/ 
* 79f04e3 - Initialize the last fec ber computed values if not found (sonic-net#3621) (2025-04-22) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mssonicbld