Closed
Conversation
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
zhenggen-xu
reviewed
Aug 10, 2018
| } | ||
|
|
||
|
|
||
| void FdbOrch::syncUpFdb() |
Collaborator
There was a problem hiding this comment.
Where this syncUpFdb() is (going to be) called?
orchagent/fdborch.cpp
Outdated
| continue; | ||
| } | ||
|
|
||
| string s = tableName + ":" + key |
Collaborator
There was a problem hiding this comment.
It would be better to not hardcode the separator.
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
jipanyang
force-pushed
the
warm_reboot_collab_6_fdb_syncup
branch
from
071fc16 to
f53f9e9
Compare
prsunny
reviewed
Aug 20, 2018
| for (const auto &key: keys) | ||
| { | ||
| sai_object_id_t bridge_port_id = SAI_NULL_OBJECT_ID; | ||
| sai_fdb_entry_type_t entryType = SAI_FDB_ENTRY_TYPE_STATIC; |
Collaborator
There was a problem hiding this comment.
IMO, the default can by DYNAMIC and check for STATIC in if statement down considering most of the FDBs learnt are dynamic
| std::string value; | ||
|
|
||
| table.hget(key, "SAI_FDB_ENTRY_ATTR_TYPE", value); | ||
| if (value == "SAI_FDB_ENTRY_TYPE_DYNAMIC") |
Contributor
Author
|
@prsunny thanks for the review! FDB sync up will require more sophisticated handling. This version of change doesn't take FDB restore into account and assumes that no previous dynamic FDB exists. Besides new FDB entries, there might be stale entries as well. Will prepare a new version to handle the case of stale FDB entries. |
Contributor
|
Closed, in favor of #615 |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Support VRF
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* [vs] Support set interface ADMIN status * [vs] Fix spelling
yejianquan
added a commit
that referenced
this pull request
Sep 3, 2025
…for-port-cntrs Temporarily disable bulk init requests for PORT counters Add temporary fix for https://github.com/aristanetworks/sonic-qual.msft/issues/655 This forces each port to be processed individually, avoiding capability mismatch between different ports in bulk requests What I did Temporarily disable bulk init requests for PORT counters. Why I did it When swss requests bulk initialization of PORT counters, corresponding component in sonic-sairedis assumes all the requested ports support same attributes, which is not the case for SFP/mgmt ports of Arista switches and was causing these ports to be completely skipped. This is supposed to be fixed by Azure/sonic-sairedis.msft#73 but it needs a re-work as its breaking non-Broadcom platform. So, we're temporarily disabling this flow. How I verified it Verified countersDB is now having all the supported counters for SFP ports. Details if related relevant threads: #558, #629, 655 signed-off-by: jianquanye@microsoft.com
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…ld (sonic-net#558) Instead of using the distro version to determine if the Python 2 bindings should be built, use deb profiles instead to specify if they should be built or not. The main reason of this is that normal .install and .dirs files can be used for both the Python 2 and Python 3 bindings, instead of .install/.dir files for Python 3 and debian/rules for Python More details on build profiles are [here](https://wiki.debian.org/BuildProfileSpec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
What I did
During orchagent warm start window, FDB may be changed. void FdbOrch::syncUpFdb() is to be called after the whole orchagent state has been restored.
Why I did it
How I verified it
VS test case to be provided once #554 is settled.
Details if related
Has dependency on #554