[cfgmgr] Use sonic-swss-common instead of exec redis-cli#392
Merged
stcheng merged 1 commit intosonic-net:masterfrom Nov 17, 2017
Merged
[cfgmgr] Use sonic-swss-common instead of exec redis-cli#392stcheng merged 1 commit intosonic-net:masterfrom
stcheng merged 1 commit intosonic-net:masterfrom
Conversation
this enforces portablity of vlanmgrd Signed-off-by: Wataru Ishida <ishida.wataru@lab.ntt.co.jp>
lguohan
approved these changes
Nov 17, 2017
stcheng
approved these changes
Nov 17, 2017
| * Dynamic switch_mac update is not supported for now. | ||
| */ | ||
| Table table(&cfgDb, "DEVICE_METADATA", CONFIGDB_TABLE_NAME_SEPARATOR); | ||
| std::vector<FieldValueTuple> ovalues; |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…net#392) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Support VRF
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…t#392) This enforces portability of vlanmgrd Signed-off-by: Wataru Ishida <ishida.wataru@lab.ntt.co.jp>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…a memory leak would have occured if the methods format() or formatArgv() were to be used more than once on the same object. This change simply ensures that currently allocated memory gets freed before new memory gets allocated. (sonic-net#392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this enforces portablity of vlanmgrd
Signed-off-by: Wataru Ishida ishida.wataru@lab.ntt.co.jp
What I did
Use
sonic-swss-commoninstead of executingredis-clito get MAC address of the device.Why I did it
This is kinda refactoring but I'm actually facing a problem with current implementation.
I'm running
redis-serverin a diffrent docker container from a container which runs sonic's daemons.Two containers shares a redis unix socket file and doesn't share a network namespace.
In this case,
vlanmgrdcrashes since current implementation executesredis-clidirectly to get MAC address.Since we are passing
DBConnector::DEFAULT_UNIXSOCKETtoDBConnector, usingsonic-swss-commoncan solve this issue.Also, we can easily add an option to
vlanmgrdfor choosing how to connect to the redis server in the future.How I verified it
Details if related