Skip to content

[buffermgr]: remove the item from consumer queue if invalid #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 2 commits into from
Apr 26, 2018
Merged

[buffermgr]: remove the item from consumer queue if invalid #489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6ef95f
[buffermgr]: remove the item from consumer queue if invalid
Apr 25, 2018
8e6dcb0
change error to task_invalid_entry
Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cfgmgr/buffermgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ task_process_status BufferMgr::doSpeedUpdateTask(string port, string speed)
{
SWSS_LOG_ERROR("Unable to create/update PG profile for port %s. No PG profile configured for speed %s and cable length %s",
port.c_str(), speed.c_str(), cable.c_str());
return task_process_status::task_failed;
return task_process_status::task_invalid_entry;
}

// Crete record in BUFFER_PROFILE table
Expand Down Expand Up @@ -232,6 +232,10 @@ void BufferMgr::doTask(Consumer &consumer)
SWSS_LOG_INFO("Unable to process table update. Will retry...");
++it;
break;
case task_process_status::task_invalid_entry:
SWSS_LOG_ERROR("Failed to process invalid entry, drop it");
it = consumer.m_toSync.erase(it);
break;
default:
it = consumer.m_toSync.erase(it);
break;
Expand Down