[portstat]: add new counters needed by snmp#453
Merged
sihuihan88 merged 2 commits intosonic-net:masterfrom Mar 19, 2018
Merged
Conversation
Signed-off-by: Sihui Han <[email protected]>
qiluo-msft
approved these changes
Mar 17, 2018
lguohan
reviewed
Mar 17, 2018
| SAI_PORT_STAT_PAUSE_TX_PKTS, | ||
| SAI_PORT_STAT_ETHER_STATS_TX_NO_ERRORS, | ||
| SAI_PORT_STAT_IP_IN_UCAST_PKTS, | ||
| SAI_PORT_STAT_ETHER_IN_PKTS_128_TO_255_OCTETS, |
Contributor
There was a problem hiding this comment.
not sure we need this one.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* add support for MCLAG Signed-off-by: shine.chen <[email protected]> * add warm-reboot support for ICCPd Signed-off-by: shine.chen <[email protected]> * ensure iccpd is there before stop iccpd Signed-off-by: shine.chen <[email protected]> * fix service function * remove unused comment * refactor code according to feature management mechanism Signed-off-by: shine.chen <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
the return value of _get_optional_services() must be iterable This bug is imported from PR sonic-net#453 Co-authored-by: shine.chen <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
This reverts commit 8aea564.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [portstat]: add new counters needed by snmp Signed-off-by: Sihui Han <[email protected]> * remove not supported SAI_QUEUE_STAT_DISCARD_DROPPED_PACKETS
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
Add missing functions for ConfigDBConnector, including - ConfigDBConnector.get_redis_client(...) - ConfigDBConnector.CONFIG_DB - ConfigDBConnector.get_redis_client(...).flushdb() - ConfigDBConnector.INIT_INDICATOR - ConfigDBConnector.db_connect(...): support optional parameters Tested in unit test: 1. this repo: add unit testcases for all the new functions. 2. sonic-config-engine 3. sonic-utilities Tested in DUT: 1. `sudo config load_minigraph -y` 2. snmpwalk snmpagent on 1.3.6.1.4.1.9.9.187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han [email protected]
What I did
SNMP requires more counters, add those accordingly.
Why I did it
How I verified it
Details if related