Skip to content

[vstest]: Add test_port_config.py which include breakout port test.#866

Merged
lguohan merged 3 commits intosonic-net:masterfrom
chiourung:tmp_port_config_test
Aug 2, 2019
Merged

[vstest]: Add test_port_config.py which include breakout port test.#866
lguohan merged 3 commits intosonic-net:masterfrom
chiourung:tmp_port_config_test

Conversation

@chiourung
Copy link
Contributor

@chiourung chiourung commented Apr 30, 2019 •
edited
Loading

[pytests] Add test_port_config.py which include breakout port test.

It needs to modify sai_create_port for virtual switch.

What I did
add test case for port breakout

Why I did it
make sure the orchagent is correct for port breakout

How I verified it
run the pytest

Details if related
It also needs to modify sai_create_port for virtual switch (sonic-net/sonic-sairedis#453)

Signed-off-by: chiourung_huang chiourung_huang@edge-core.com

@chiourung
Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
be700cd 
[pytests] Add test_port_config.py which include breakout port test.

It needs to modify sai_create_port for virtual switch.
@chiourung
Copy link
Contributor Author

chiourung commented Apr 30, 2019 •
edited
Loading

The test_port_breakout needs to merge the commit in sonic-sairedis. (sonic-net/sonic-sairedis#453)
After merge (sonic-net/sonic-sairedis#453), it can pass the test_port_breakout.

@yehjunying yehjunying mentioned this pull request May 3, 2019
Closed
@chiourung chiourung changed the title Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> [pytests] Add test_port_config.py which include breakout port test. May 3, 2019
@chiourung chiourung mentioned this pull request May 13, 2019
Merged
@chiourung
Copy link
Contributor Author

chiourung commented Jun 12, 2019

retest this please

3 similar comments
@chiourung
Copy link
Contributor Author

chiourung commented Jun 13, 2019

retest this please

@chiourung
Copy link
Contributor Author

chiourung commented Jun 14, 2019

retest this please

@chiourung
Copy link
Contributor Author

chiourung commented Jun 17, 2019

retest this please

@chiourung
Copy link
Contributor Author

chiourung commented Jun 17, 2019

@lguohan , May you help to review? Thanks.

stcheng
stcheng suggested changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix.

@lguohan
Copy link
Contributor

lguohan commented Jun 19, 2019

retest this please

@stcheng
Copy link
Contributor

stcheng commented Jul 16, 2019

retest this please

1 similar comment
@chiourung
Copy link
Contributor Author

chiourung commented Jul 18, 2019

retest this please

@stcheng
Copy link
Contributor

stcheng commented Jul 19, 2019

Retest this please

1 similar comment
@chiourung
Copy link
Contributor Author

chiourung commented Jul 24, 2019

Retest this please

@stcheng stcheng changed the title [pytests] Add test_port_config.py which include breakout port test. [portsorch]: Add port breakout support for VS and related VS tests Jul 24, 2019
@lguohan
Copy link
Contributor

lguohan commented Aug 1, 2019

retest this please

@lguohan lguohan changed the title [portsorch]: Add port breakout support for VS and related VS tests [vstest]: Add test_port_config.py which include breakout port test. Aug 1, 2019
@lguohan lguohan merged commit 6301abe into sonic-net:master Aug 2, 2019
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@rajendra-dendukuri
[doc]: ZTP configuration and show commands (sonic-net#866)
d950192
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@kcudnik
[syncd] Fix access coldvid table per switch (sonic-net#866)
f50dba7 
Signed-off-by: kcudnik <kcudnik@gmail.com>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@chiourung @lguohan
[vstest]: Add test_port_config.py which include breakout port test. (s…
322a55a 
…onic-net#866)

* Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
@mlok-nokia
[Chassis][database][sonic-db-cli] Fix the instance database# failed t…
5922fdc 
…o start up in LC (sonic-net#866)

### Why I did it
On multiasic LC,  instance database# failed to start due to the sonic-db-cli -n asic# PING failed.  soinc-db-cli -n asic0 PING failed which results in the /usr/bin/database.sh wait forever in the postStartAction(). Fixes sonic-net/sonic-buildimage#18395

#### How I did it
On multiasic LC,  sonic-db-cli -n asic0 PING has been fixed/changed by PR   sonic-net/sonic-swss-common#797.  But when execute "sonic-db-cli -n asic0 PING" command, it will fail to ping the CHASSIS_STATE_DB and CHASSIS_APP_DB in the database-chassis on the supervisor card.  The existing code uses db_name to check against 
 "redis_chassis.server" identify if it is for database-chassis is wrong.  This commit uses  variable "host" instead of db_name.  This will fix the issue.

#### How to verify it
1. Boot up the chassis, execuet " docker ps" to verify the instance database0 and database1 containers are up.
```
admin@ixre-egl-board40:~$ docker ps 
CONTAINER ID   IMAGE                                COMMAND                  CREATED          STATUS          PORTS     NAMES
d2dc397d420a   docker-macsec:latest                 "/usr/local/bin/supe?"   34 minutes ago   Up 34 minutes             macsec
fd60a96fcb67   docker-snmp:latest                   "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                snmp
168cf9ae286d   docker-platform-monitor:latest       "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                pmon
9f1c69112fdb   docker-sonic-mgmt-framework:latest   "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                mgmt-framework
01cb833ab7b6   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp1
ec6a965669eb   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp0
16dd25d29d7b   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp
46ce9b823873   docker-sonic-gnmi:latest             "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                gnmi
5f36560338e0   docker-fpm-frr:latest                "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                bgp1
3b1abe66e7a1   docker-fpm-frr:latest                "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                bgp0
85cd5b6cdd05   docker-router-advertiser:latest      "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                radv
ca8f79f69122   docker-teamd:latest                  "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                teamd0
5fe4b55ac62e   docker-syncd-brcm-dnx:latest         "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                syncd1
81b6ef493818   docker-syncd-brcm-dnx:latest         "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                syncd0
4e32dd244b65   docker-teamd:latest                  "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                teamd1
4f83bee7ffba   docker-orchagent:latest              "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                swss0
4e2c047effa8   docker-orchagent:latest              "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                swss1
0b6d7e742c0f   docker-eventd:latest                 "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                eventd
5c77bae968e0   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database1
d4616de64435   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database0
27403c8acffa   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stcheng stcheng stcheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chiourung @lguohan @stcheng