Revert "Orchagent changes needed to support single ASIC VOQ Fixed-System"

[yxieca]

Reverts #3847

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

This PR reverts PR #3847, which added support for single ASIC VOQ (Virtual Output Queue) Fixed-System. The revert removes the conditional logic that allowed VOQ switches to operate in a standalone mode without chassis database connectivity, reverting back to requiring CHASSIS_APP_DB connection for all VOQ switch types.

Key changes:

• Removed gMultiAsicVoq global flag and isChassisDbInUse() helper function, reverting to direct gMySwitchType == "voq" checks
• Eliminated test infrastructure for single ASIC VOQ fixed-system mode, including test configurations and command-line options
• Removed conditional CHASSIS_APP_DB connection logic that enabled standalone VOQ operation

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/virtual_chassis/database_config.json	Deleted database configuration file used for testing virtual chassis setup with single ASIC VOQ
tests/single_asic_voq_fs/default_config.json	Deleted default configuration for single ASIC VOQ fixed-system test mode
tests/conftest.py	Removed --switch-mode parameter, SINGLE_ASIC_VOQ_FS constant, and related conditional logic for handling single ASIC VOQ test mode
tests/mock_tests/mock_orchagent_main.cpp	Removed mock implementations of gMultiAsicVoq and isChassisDbInUse()
orchagent/p4orch/tests/test_main.cpp	Removed mock implementations of gMultiAsicVoq and isChassisDbInUse()
orchagent/main.cpp	Removed gMultiAsicVoq flag, isChassisDbInUse() function, and isChassisAppDbPresent() function; restored unconditional CHASSIS_APP_DB connection for VOQ switches
orchagent/portsorch.cpp	Reverted VOQ detection from isChassisDbInUse() to gMySwitchType == "voq" for LAG operations and port status updates
orchagent/neighorch.cpp	Reverted VOQ detection from isChassisDbInUse() to gMySwitchType == "voq" for neighbor synchronization
orchagent/intfsorch.cpp	Reverted VOQ detection from isChassisDbInUse() to gMySwitchType == "voq" for interface operations
.azure-pipelines/test-docker-sonic-vs-template.yml	Removed single ASIC VOQ test execution from CI pipeline
.azure-pipelines/docker-sonic-vs/start.sh	Removed conditional VOQ configuration file handling during container startup

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[yijingyan2]

sonic-net/sonic-buildimage@71f390d
by reverting this pr, the kvmtest passed for t2

[prsunny]

@tjchadaga , would you check on this? need the t2 kvm fix before we can re-merge this.

[saiarcot895]

Orchagent crash backtrace seen on T2 KVM:

#0  0x00007f1570b65828 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string (this=0x7fff0ffdeb80, __str=<error reading variable: Cannot access memory at address 0x30>)
    at /build/reproducible-path/gcc-12-12.2.0/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.h:544
#1  0x00005582ac5cefe2 in swss::TableBase::getTableNameSeparator[abi:cxx11]() const (this=<optimized out>) at /usr/include/swss/table.h:82
#2  NeighOrch::voqSyncAddNeigh (this=this@entry=0x7f156fc53400, alias="vlab-t2-1-1|asic0|Ethernet-IB0", ip_address=..., mac=..., neighbor_entry=...) at ./orchagent/neighorch.cpp:2296
#3  0x00005582ac5cf8a4 in NeighOrch::addInbandNeighbor (this=this@entry=0x7f156fc53400, alias="vlab-t2-1-1|asic0|Ethernet-IB0", ip_address=...) at ./orchagent/neighorch.cpp:2130
#4  0x00005582ac5ea714 in IntfsOrch::setIntf (this=this@entry=0x7f156e7fae00, alias="Ethernet-IB0", vrf_id=vrf_id@entry=844424930132007, ip_prefix=ip_prefix@entry=0x7fff0ffdfed0, adminUp=<optimized out>, mtu=<optimized out>, loopbackAction="")
    at ./orchagent/intfsorch.cpp:591
#5  0x00005582ac5ec07f in IntfsOrch::doTask (this=0x7f156e7fae00, consumer=...) at ./orchagent/intfsorch.cpp:965
#6  0x00005582ac5698f3 in Consumer::execute (this=0x7f156e78a600) at ./orchagent/orch.cpp:338
#7  0x00005582ac557bb0 in OrchDaemon::start (this=this@entry=0x7f156fc3e970, heartBeatInterval=heartBeatInterval@entry=10000) at ./orchagent/orchdaemon.cpp:980
#8  0x00005582ac49336a in main (argc=<optimized out>, argv=<optimized out>) at ./orchagent/main.cpp:965

Trigger of segfault:

(gdb) frame 2
#2  NeighOrch::voqSyncAddNeigh (this=this@entry=0x7f156fc53400, alias="vlab-t2-1-1|asic0|Ethernet-IB0", ip_address=..., mac=..., neighbor_entry=...) at ./orchagent/neighorch.cpp:2296
2296    in ./orchagent/neighorch.cpp
(gdb) print m_tableVoqSystemNeighTable
$5 = std::unique_ptr<swss::Table> = {get() = 0x0}