Skip to content

Orchagent changes needed to support single ASIC VOQ Fixed-System#3847

Merged
prsunny merged 45 commits intosonic-net:masterfrom
lakshmi-nexthop:single_voq_swss
Nov 21, 2025
Merged

Orchagent changes needed to support single ASIC VOQ Fixed-System#3847
prsunny merged 45 commits intosonic-net:masterfrom
lakshmi-nexthop:single_voq_swss

Conversation

@lakshmi-nexthop
Copy link
Contributor

What I did

  • Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
  • For lag creation, system lags are created as the switch is a VOQ swtich.

Why I did it

  • For a fixed system, there is no chassis DB present

How I verified it

  • Ran sonic-mgmt tests to verify BGP, LAG, functionality

Details if related

  • Recirc ports are pending more investigation (need to understand if theres a need for recirc ports).
  • There are no inband ports present. (this is also a pending change)

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lakshmi-nexthop lakshmi-nexthop marked this pull request as ready for review August 29, 2025 17:00
@lakshmi-nexthop lakshmi-nexthop changed the title Orchagent changes needed to support VOQ FS Orchagent changes needed to support single ASIC VOQ Fixed-System Oct 1, 2025
@abdosi
Copy link
Contributor

abdosi commented Oct 1, 2025

Please add UT for code-coverage.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run

@prsunny prsunny merged commit 5671e08 into sonic-net:master Nov 21, 2025
15 checks passed
yijingyan2 added a commit to yijingyan2/sonic-swss that referenced this pull request Dec 3, 2025
yxieca added a commit that referenced this pull request Dec 5, 2025
prsunny pushed a commit that referenced this pull request Dec 5, 2025
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-swss that referenced this pull request Dec 10, 2025
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-swss that referenced this pull request Dec 10, 2025
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Lakshmi <[email protected]>
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-swss that referenced this pull request Dec 10, 2025
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Lakshmi <[email protected]>
Signed-off-by: Saravanan <[email protected]>
kalash-nexthop pushed a commit to kalash-nexthop/sonic-swss that referenced this pull request Dec 16, 2025
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Kalash Nainwal <[email protected]>
kalash-nexthop pushed a commit to kalash-nexthop/sonic-swss that referenced this pull request Dec 16, 2025
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-swss that referenced this pull request Dec 23, 2025
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Lakshmi <[email protected]>
Signed-off-by: Saravanan <[email protected]>
Signed-off-by: Saravanan Sellappa <[email protected]>
prsunny pushed a commit that referenced this pull request Jan 5, 2026
What I did
Orchagent changes needed to support single ASIC VOQ Fixed-System (#3847) was reverted via (#4035) because
vms-kvm-t2 tests were failing.
That was because the isChassisAppDbPresent() was using an incorrect path to database_config.json
This PR brings back the original #3847 and fixes the isChassisAppDbPresent() to use the correct path.

Why I did it
Single-asic VOQ systems do need #3847
mssonicbld added a commit to mssonicbld/sonic-swss that referenced this pull request Jan 5, 2026
<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**
Orchagent changes needed to support single ASIC VOQ Fixed-System (sonic-net#3847) was reverted via (sonic-net#4035) because
vms-kvm-t2 tests were failing.
That was because the `isChassisAppDbPresent()` was using an incorrect path to `database_config.json`
This PR brings back the original sonic-net#3847 and fixes the `isChassisAppDbPresent()` to use the correct path.

**Why I did it**
Single-asic VOQ systems do need sonic-net#3847

**How I verified it**
Tests on vms-kvm-t2 and also single-asic voq systems
Verified on vms-kvm-t2 the test_bgp_fact is passing
```
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-1-0] PASSED [ 25%]
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-1-1] PASSED [ 50%]
bgp/test_bgp_fact.py::test_bgp_facts[lvlab-t2-1-2-0] PASSED [ 75%]
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-2-1] PASSED [100%]
```

**Details if related**
mssonicbld added a commit that referenced this pull request Jan 5, 2026
<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**
Orchagent changes needed to support single ASIC VOQ Fixed-System (#3847) was reverted via (#4035) because
vms-kvm-t2 tests were failing.
That was because the `isChassisAppDbPresent()` was using an incorrect path to `database_config.json`
This PR brings back the original #3847 and fixes the `isChassisAppDbPresent()` to use the correct path.

**Why I did it**
Single-asic VOQ systems do need #3847

**How I verified it**
Tests on vms-kvm-t2 and also single-asic voq systems
Verified on vms-kvm-t2 the test_bgp_fact is passing
```
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-1-0] PASSED [ 25%]
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-1-1] PASSED [ 50%]
bgp/test_bgp_fact.py::test_bgp_facts[lvlab-t2-1-2-0] PASSED [ 75%]
bgp/test_bgp_fact.py::test_bgp_facts[vlab-t2-1-2-1] PASSED [100%]
```

**Details if related**
Pterosaur pushed a commit to Janetxxx/sonic-swss that referenced this pull request Jan 6, 2026
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality
Pterosaur pushed a commit to Janetxxx/sonic-swss that referenced this pull request Jan 6, 2026
Pterosaur pushed a commit to Janetxxx/sonic-swss that referenced this pull request Jan 6, 2026
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality
Pterosaur pushed a commit to Janetxxx/sonic-swss that referenced this pull request Jan 6, 2026
yehjunying pushed a commit to yehjunying/sonic-swss that referenced this pull request Jan 16, 2026
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality
arpit-nexthop pushed a commit to nexthop-ai/sonic-swss that referenced this pull request Jan 21, 2026
What I did
Orchagent changes needed to support single ASIC VOQ Fixed-System (sonic-net#3847) was reverted via (sonic-net#4035) because
vms-kvm-t2 tests were failing.
That was because the isChassisAppDbPresent() was using an incorrect path to database_config.json
This PR brings back the original sonic-net#3847 and fixes the isChassisAppDbPresent() to use the correct path.

Why I did it
Single-asic VOQ systems do need sonic-net#3847
ganglyu pushed a commit to ganglyu/sonic-swss that referenced this pull request Jan 26, 2026
What I did
Orchagent changes needed to support single ASIC VOQ Fixed-System (sonic-net#3847) was reverted via (sonic-net#4035) because
vms-kvm-t2 tests were failing.
That was because the isChassisAppDbPresent() was using an incorrect path to database_config.json
This PR brings back the original sonic-net#3847 and fixes the isChassisAppDbPresent() to use the correct path.

Why I did it
Single-asic VOQ systems do need sonic-net#3847

Signed-off-by: ganglyu <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Feb 4, 2026
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Lawrence Lee <[email protected]>
baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request Feb 23, 2026
…ic-net#3847)

What I did

Portorch, Neighorch, Intfsorch are updated to not access chassis app DB. Chassis app DB is accessed only if the chassisdb.conf is present indicating its a real chassis (not a FS VOQ)
For lag creation, system lags are created as the switch is a VOQ swtich.
Why I did it

For a fixed system, there is no chassis DB present
How I verified it

Ran sonic-mgmt tests to verify BGP, LAG, functionality

Signed-off-by: Baorong Liu <[email protected]>
baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request Feb 23, 2026
baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request Feb 23, 2026
What I did
Orchagent changes needed to support single ASIC VOQ Fixed-System (sonic-net#3847) was reverted via (sonic-net#4035) because
vms-kvm-t2 tests were failing.
That was because the isChassisAppDbPresent() was using an incorrect path to database_config.json
This PR brings back the original sonic-net#3847 and fixes the isChassisAppDbPresent() to use the correct path.

Why I did it
Single-asic VOQ systems do need sonic-net#3847

Signed-off-by: Baorong Liu <[email protected]>
@lakshmi-nexthop lakshmi-nexthop deleted the single_voq_swss branch March 19, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

10 participants