Populate the Voq system Port information for the local port when the Port is removed and created when the Speed is changed dynamically via GCU by saksarav-nokia · Pull Request #3976 · sonic-net/sonic-swss

saksarav-nokia · 2025-11-06T16:53:50Z

…

What I did
Fixed the issue reported in sonic-net/sonic-buildimage#24417
Added code to populate the system_port information in the New Port structure in orchagent portsorch after the Port is removed and created when the Port speed is changed via GCU patch.

Why I did it
When the switch is created, swss queries all the SYSTEM_PORTS from SAI and updates the PORT class/structure with the corresponding system_port info after the PortInitDone event is received from portsyncd.
Then the port speed is changed with 4 Lanes via GCU patch, the port is removed from SAI and created again in swss by calling deInitPort and initPort. But in initPort, the system_port info is not updated in the new PORT structure.
So when the RIF is created on local interface, the voqSyncAddIntf adds an entry in SYSTEM_INTERFACE table in CHASSIS_APP_DB with empty key since the system_port info is not populated for the local port. For the same reason, the SYSTEM_NEIGH info is also not updated in CHASSIS_APP_DB. This breaks the basic VOQ functionality

How I verified it
Verified that the VOQ functionality works as expected with the traffic with multi-asic after the GCU patch
Details if related

…Port is removed and created when the Speed is changed dynamically via GCU Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

mssonicbld · 2025-11-06T16:53:58Z

/azp run

azure-pipelines · 2025-11-06T16:54:09Z

Azure Pipelines successfully started running 1 pipeline(s).

saksarav-nokia · 2025-11-06T16:55:39Z

@arlakshm @vmittal-msft @deepak-singhal0408 @rlhui
I will open it for review after we do some basic testing with master image. We have tested only with msft-2405 and it looks good.

…e front panel port so the removePort will be successful Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

mssonicbld · 2025-11-07T23:51:35Z

/azp run

azure-pipelines · 2025-11-07T23:51:45Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-08T19:12:21Z

/azp run

azure-pipelines · 2025-11-08T19:12:31Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/test_virtual_chassis.py

saksarav-nokia · 2025-11-10T13:51:52Z

/azpw run

mssonicbld · 2025-11-10T13:51:55Z

/AzurePipelines run

azure-pipelines · 2025-11-10T13:52:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

mssonicbld · 2025-11-10T14:09:58Z

/azp run

azure-pipelines · 2025-11-10T14:10:08Z

Azure Pipelines successfully started running 1 pipeline(s).

deepak-singhal0408 · 2025-11-12T18:04:53Z

Thanks @saksarav-nokia . Solution looks good to me.

saksarav-nokia · 2025-11-12T19:21:56Z

Verified the fix also in master

mssonicbld · 2025-11-12T19:24:07Z

/azp run

azure-pipelines · 2025-11-12T19:24:14Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

saksarav-nokia · 2025-11-13T15:23:43Z

Created Azure/sonic-swss.msft#167 for msft-2405

prsunny · 2025-11-17T17:54:07Z

orchagent/portsorch.cpp

+         return;
+     }
+
+     if ((gMySwitchType == "voq") && (port.m_type == Port::PHY))


This may need to be addressed as per this PR - #3847

This may need to be addressed as per this PR - #3847

@prsunny , The PR #3847 added the isChassisDbInUse check only if it needs to access the CHASSIS_DB. But the code changes in this PR doesn't read/write from CHASSIS_DB and it just reads from APP_DB and update the Port structure

mssonicbld · 2025-11-24T22:16:38Z

/azp run

azure-pipelines · 2025-11-24T22:16:48Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-25T18:39:23Z

/azp run

azure-pipelines · 2025-11-25T18:39:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-27T13:00:01Z

/azp run

azure-pipelines · 2025-11-27T13:00:14Z

Azure Pipelines successfully started running 1 pipeline(s).

…Port is removed and created when the Speed is changed dynamically via GCU (sonic-net#3976) What I did Fixed the issue reported in sonic-net/sonic-buildimage#24417 Added code to populate the system_port information in the New Port structure in orchagent portsorch after the Port is removed and created when the Port speed is changed via GCU patch. Why I did it When the switch is created, swss queries all the SYSTEM_PORTS from SAI and updates the PORT class/structure with the corresponding system_port info after the PortInitDone event is received from portsyncd. Then the port speed is changed with 4 Lanes via GCU patch, the port is removed from SAI and created again in swss by calling deInitPort and initPort. But in initPort, the system_port info is not updated in the new PORT structure. So when the RIF is created on local interface, the voqSyncAddIntf adds an entry in SYSTEM_INTERFACE table in CHASSIS_APP_DB with empty key since the system_port info is not populated for the local port. For the same reason, the SYSTEM_NEIGH info is also not updated in CHASSIS_APP_DB. This breaks the basic VOQ functionality Signed-off-by: Kalash Nainwal <kalash@nexthop.ai>

…Port is removed and created when the Speed is changed dynamically via GCU (sonic-net#3976) What I did Fixed the issue reported in sonic-net/sonic-buildimage#24417 Added code to populate the system_port information in the New Port structure in orchagent portsorch after the Port is removed and created when the Port speed is changed via GCU patch. Why I did it When the switch is created, swss queries all the SYSTEM_PORTS from SAI and updates the PORT class/structure with the corresponding system_port info after the PortInitDone event is received from portsyncd. Then the port speed is changed with 4 Lanes via GCU patch, the port is removed from SAI and created again in swss by calling deInitPort and initPort. But in initPort, the system_port info is not updated in the new PORT structure. So when the RIF is created on local interface, the voqSyncAddIntf adds an entry in SYSTEM_INTERFACE table in CHASSIS_APP_DB with empty key since the system_port info is not populated for the local port. For the same reason, the SYSTEM_NEIGH info is also not updated in CHASSIS_APP_DB. This breaks the basic VOQ functionality

…Port is removed and created when the Speed is changed dynamically via GCU (sonic-net#3976) What I did Fixed the issue reported in sonic-net/sonic-buildimage#24417 Added code to populate the system_port information in the New Port structure in orchagent portsorch after the Port is removed and created when the Port speed is changed via GCU patch. Why I did it When the switch is created, swss queries all the SYSTEM_PORTS from SAI and updates the PORT class/structure with the corresponding system_port info after the PortInitDone event is received from portsyncd. Then the port speed is changed with 4 Lanes via GCU patch, the port is removed from SAI and created again in swss by calling deInitPort and initPort. But in initPort, the system_port info is not updated in the new PORT structure. So when the RIF is created on local interface, the voqSyncAddIntf adds an entry in SYSTEM_INTERFACE table in CHASSIS_APP_DB with empty key since the system_port info is not populated for the local port. For the same reason, the SYSTEM_NEIGH info is also not updated in CHASSIS_APP_DB. This breaks the basic VOQ functionality Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>

Populate the Voq system Port information for the local port when the …

5d3b0ae

…Port is removed and created when the Speed is changed dynamically via GCU Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

Fix the Unit test to remove the QUEUE configured on system_port of th…

f25f440

…e front panel port so the removePort will be successful Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

github-advanced-security bot found potential problems Nov 8, 2025

View reviewed changes

tests/test_virtual_chassis.py Fixed Show fixed Hide fixed

Fix the Unit test failure

29019f9

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

saksarav-nokia force-pushed the saksarav-nokia-GCU-system-port branch from 3d8f622 to 29019f9 Compare November 10, 2025 14:09

vmittal-msft self-requested a review November 11, 2025 01:18

vmittal-msft added this to SONiC Chassis Nov 11, 2025

abdosi requested a review from arlakshm November 12, 2025 18:10

abdosi added the Request for msft-202405 Branch label Nov 12, 2025

mssonicbld added the Cherry Pick Conflict_msft-202405 label Nov 12, 2025

saksarav-nokia marked this pull request as ready for review November 12, 2025 19:21

saksarav-nokia requested review from abdosi, judyjoseph and prsunny as code owners November 12, 2025 19:21

Merge branch 'master' into saksarav-nokia-GCU-system-port

66fcecc

deepak-singhal0408 approved these changes Nov 12, 2025

View reviewed changes

arlakshm approved these changes Nov 14, 2025

View reviewed changes

prsunny reviewed Nov 17, 2025

View reviewed changes

Merge branch 'master' into saksarav-nokia-GCU-system-port

fbe58d8

Merge branch 'master' into saksarav-nokia-GCU-system-port

e397a12

Merge branch 'master' into saksarav-nokia-GCU-system-port

2cdb131

prsunny merged commit 48e28b6 into sonic-net:master Nov 28, 2025
15 checks passed

github-project-automation bot moved this to Done in SONiC Chassis Nov 28, 2025

Conversation

saksarav-nokia commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Nov 6, 2025

Uh oh!

azure-pipelines bot commented Nov 6, 2025

Uh oh!

saksarav-nokia commented Nov 6, 2025

Uh oh!

mssonicbld commented Nov 7, 2025

Uh oh!

azure-pipelines bot commented Nov 7, 2025

Uh oh!

mssonicbld commented Nov 8, 2025

Uh oh!

azure-pipelines bot commented Nov 8, 2025

Uh oh!

Uh oh!

saksarav-nokia commented Nov 10, 2025

Uh oh!

mssonicbld commented Nov 10, 2025

Uh oh!

azure-pipelines bot commented Nov 10, 2025

Uh oh!

mssonicbld commented Nov 10, 2025

Uh oh!

azure-pipelines bot commented Nov 10, 2025

Uh oh!

deepak-singhal0408 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saksarav-nokia commented Nov 12, 2025

Uh oh!

mssonicbld commented Nov 12, 2025

Uh oh!

azure-pipelines bot commented Nov 12, 2025

Uh oh!

saksarav-nokia commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

saksarav-nokia Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Nov 24, 2025

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

mssonicbld commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mssonicbld commented Nov 27, 2025

Uh oh!

azure-pipelines bot commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

saksarav-nokia commented Nov 6, 2025 •

edited

Loading

deepak-singhal0408 commented Nov 12, 2025 •

edited

Loading

saksarav-nokia commented Nov 13, 2025 •

edited

Loading