Skip to content

[Marvell-Teralynx][PFCWD]: Fix pfc_detect filename to align with asic_type#3968

Merged
prsunny merged 13 commits intosonic-net:masterfrom
jithenderkondam:plat_name_fix
Mar 10, 2026
Merged

[Marvell-Teralynx][PFCWD]: Fix pfc_detect filename to align with asic_type#3968
prsunny merged 13 commits intosonic-net:masterfrom
jithenderkondam:plat_name_fix

Conversation

@jithenderkondam
Copy link
Copy Markdown
Contributor

@jithenderkondam jithenderkondam commented Oct 31, 2025

Description:
Change pfc_detect filename from pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua to align with asic_type naming convention.

This fix addresses the naming inconsistency introduced in PR #3252 and ensures the filename matches the expected asic_type format used throughout the codebase.

What I did:

  • Renamed pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua
  • Updated Makefile.am to reference the renamed file

Why I did it:

  • Fix the naming of pfc_detect file to align with asic_type convention
  • Maintain consistency with platform naming standards

How I verified it:
Run the pfc_wd SONiC PTF test cases.

Which release branch to backport (provide reason below if selected):

  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version):
202505

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Oct 31, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jithenderkondam / name: jithenderkondam (a3ebd2a)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

prsunny
prsunny previously approved these changes Nov 3, 2025
Copy link
Copy Markdown
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @kperumalbfn , can you check. will this have any compatibility issue?

@jithenderkondam
Copy link
Copy Markdown
Contributor Author

@prsunny the changes are specific to Marvell-Teralynx and there are no compatibility issue.
@kperumalbfn , can you please take a look ?

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jithenderkondam
Copy link
Copy Markdown
Contributor Author

@kperumalbfn , can you please take a look ?

pfc_detect_marvell-teralynx.lua \
pfc_detect_mellanox.lua \
pfc_detect_broadcom.lua \
pfc_detect_marvell_prestera.lua \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jithenderkondam could you update marvell_prestera.lua as well

Copy link
Copy Markdown
Contributor Author

@jithenderkondam jithenderkondam Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn I have updated the marvell_prestera.lua. Could you please take a look.
Also please help to back port the fix to 202505. Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn Could you review the changes

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

pfc_detect_mellanox.lua \
pfc_detect_broadcom.lua \
pfc_detect_marvell_prestera.lua \
pfc_detect_marvell-prestera.lua \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jithenderkondam how about renaming the actual lua script? Please update

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn Thanks for pointing that out! I’ve updated the file name.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn
kperumalbfn previously approved these changes Nov 19, 2025
@jithenderkondam
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jithenderkondam
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jithenderkondam
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #4322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants