[Marvell] platform renaming for innovium#3252
Conversation
|
This seems to be a breaking change to me. Can you confirm if this can be merged and not break existing platform? |
|
@prsunny This PR wont break existing platform builds and also the functionalty of marvell(renamed as marvell-prestera) and innovium(renamed as marvell-teralynx) platforms. Also this has sonic-buildimage changes to enable respective platform builds in sonic master repo. Pls let me know if you see any specific concerns/breakages even with the additional changes in sonic-buildimage, sonic-sairedis and sonic-utilities PRs below. |
krismarvell
force-pushed
the
merge_tl
branch
from
8193fc9 to
81222c3
Compare
|
@prsunny I see code coverage failing. Is there a way to bypass vstest ? If not, may need your help as to how to trace the code coverage errors. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@krismarvell , we can merge this PR once you confirm its ready. Do you've an order of merge dependency? Which PR should be going first? |
|
@prsunny For the successful image build, i think it can be merged in any order and hence this swss change can be merged indepently. Pls let me know if you think otherwise. the sonic-swss submodule update into sonic-buildimage will happen subsequently ? |
submodule update is automated. It can happen in the next day itself. Is it going to break anything for this platform? |
|
@prsunny this merge is not going to break the build |
krismarvell
force-pushed
the
merge_tl
branch
2 times, most recently
from
647c73d to
8b0521b
Compare
|
Platform renaming, and bypassing coverage |
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
…_type (#3968) Description: Change pfc_detect filename from pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua to align with asic_type naming convention. This fix addresses the naming inconsistency introduced in PR #3252 and ensures the filename matches the expected asic_type format used throughout the codebase. What I did: Renamed pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua Updated Makefile.am to reference the renamed file Why I did it: Fix the naming of pfc_detect file to align with asic_type convention Maintain consistency with platform naming standards
…_type **Description:** Change pfc_detect filename from pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua to align with asic_type naming convention. This fix addresses the naming inconsistency introduced in PR sonic-net#3252 and ensures the filename matches the expected asic_type format used throughout the codebase. **What I did:** - Renamed pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua - Updated Makefile.am to reference the renamed file **Why I did it:** - Fix the naming of pfc_detect file to align with asic_type convention - Maintain consistency with platform naming standards **How I verified it:** Run the pfc_wd SONiC PTF test cases. **Which release branch to backport (provide reason below if selected):** - [ ] 202405 - [ ] 202411 - [x] 202505 - [x] 202511 **Tested branch (Please provide the tested image version):** 202505 <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
3 participants
What I did
asic type checks for innovium platforms renamed
Why I did it
asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
How I verified it
Run sonic-ptf on ACL and PFC modules to make sure the change does not impact existing functionality
Details if related