Enhance return code handling for queryEnumCapabilitiesSai() by justin-wong-ce · Pull Request #3778 · sonic-net/sonic-swss

justin-wong-ce · 2025-07-22T17:15:47Z

Backport to msft-202412, msft-202503, 202505

What I did
Change the return code handling such that it does not produce an ERR level syslog in the case that SAI_STATUS_NOT_SUPPORTED is returned. Instead handle it gracefully.

Why I did it
Sonic seems to expect queryEnumCapabilitiesSai() to only be sucessful when it returns SAI_STATUS_SUCCESS. However, SAI_STATUS_NOT_SUPPORTED is also a valid return code if the attribute queried is not supported on a platform.

How I verified it
Tested with 7260CX3 on 202505, new log msg prints in place of previous ERR log

Details if related

Sonic seems to expect queryEnumCapabilitiesSai() to only be sucessful when it returns SAI_STATUS_SUCCESS. However, SAI_STATUS_NOT_SUPPORTED is also a valid return code if the attribute queried is not supported on a platform. Change the return code handling such that it does not produce an ERR level syslog in the case that SAI_STATUS_NOT_SUPPORTED is returned. Instead handle it gracefully. Tested with 7260CX3 on 202505

mssonicbld · 2025-07-22T17:15:54Z

/azp run

azure-pipelines · 2025-07-22T17:16:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-24T16:14:17Z

/azp run

azure-pipelines · 2025-07-24T16:14:27Z

Azure Pipelines successfully started running 1 pipeline(s).

justin-wong-ce · 2025-07-24T16:14:47Z

/azpw run Azure.sonic-swss

mssonicbld · 2025-07-24T16:14:49Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2025-07-24T16:14:58Z

Azure Pipelines successfully started running 1 pipeline(s).

justin-wong-ce · 2025-07-25T23:33:33Z

/azpw run Azure.sonic-swss

mssonicbld · 2025-07-25T23:33:35Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2025-07-25T23:33:44Z

Azure Pipelines successfully started running 1 pipeline(s).

dhanasekar-arista · 2025-07-28T18:24:01Z

#3765
This PR has introduced few more errors w.r.t "SAI_SWITCH_ATTR_PACKET_TRIM_*" which should needs to be handled gracefully.

r12f · 2025-07-29T21:56:30Z

orchagent/switch/trimming/capabilities.cpp

        attrCap, SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE
    );
-    if (status != SAI_STATUS_SUCCESS)
+    if (status == SAI_STATUS_NOT_SUPPORTED)


do you mind to update the other functions in this file?

otherwise this looks good.

do you mind to update the other functions in this file?

done, #3798

mssonicbld · 2025-07-30T13:59:12Z

/azp run

azure-pipelines · 2025-07-30T13:59:22Z

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn · 2025-07-30T17:15:58Z

orchagent/switch/trimming/capabilities.cpp

        mList, SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE
    );
-    if (status != SAI_STATUS_SUCCESS)
+    if (status == SAI_STATUS_NOT_SUPPORTED)


@nazariig please check

kperumalbfn · 2025-07-30T17:17:56Z

orchagent/switch/trimming/capabilities.cpp

-    if (status != SAI_STATUS_SUCCESS)
+    if (status == SAI_STATUS_NOT_SUPPORTED)
+    {
+        SWSS_LOG_NOTICE(


@adyeung @justin-wong-ce we also need to update the

sonic-swss/orchagent/switch/trimming/capabilities.cpp

Line 141 in 5e7e42c

bool SwitchTrimmingCapabilities::isSwitchTrimmingSupported() const

Will be addressing this in a separate PR.
(Someone else doing it since I don't have computer access for a bit soon).

@kperumalbfn the next SAI 13.2.1 drop will pass the AttrSupported checks required by isSwitchTrimmingSupported(), no need for a change at the func from BRCM

Thanks @adyeung @justin-wong-ce

kperumalbfn

LGTM

nazariig · 2025-08-01T16:35:52Z

orchagent/switch/trimming/capabilities.cpp

+    if (status == SAI_STATUS_NOT_SUPPORTED)
+    {
+        SWSS_LOG_NOTICE(
+            "Attribute not supported(%s)enum value capabilities",


Suggested change

"Attribute not supported(%s)enum value capabilities",

"Attribute not supported(%s) to query enum value capabilities",

nazariig · 2025-08-01T16:37:29Z

orchagent/switch/trimming/capabilities.cpp

+    if (status == SAI_STATUS_NOT_SUPPORTED)
+    {
+        SWSS_LOG_NOTICE(
+            "Attribute not supported(%s)enum value capabilities",


Suggested change

"Attribute not supported(%s)enum value capabilities",

"Attribute not supported(%s) to query attr vapabilities",

@nazariig Justin is on vacation, i've addressed these in this PR #3808.
Please review and proceed with the merge.

@dhanasekar-arista the new one is approved. Please close the original one

thanks @nazariig , i wont have permissions to close this one, @justin-wong-ce will close this one once he is back.

@dhanasekar-arista PR has been closed

Backport to msft-202412, msft-202503, 202505  **What I did** Change the return code handling such that it does not produce an ERR level syslog in the case that SAI_STATUS_NOT_SUPPORTED is returned. Instead handle it gracefully. **Why I did it** Sonic seems to expect queryEnumCapabilitiesSai() to only be sucessful when it returns SAI_STATUS_SUCCESS. However, SAI_STATUS_NOT_SUPPORTED is also a valid return code if the attribute queried is not supported on a platform. **How I verified it** Verified that the new LOG messages are printed at NOTICE level rather than ERROR level. SONiC Software Version: SONiC.branch.202505-ars.ca6b34cb-buildimage.origin.202505-review.478334.1-2025.07.30.06.38 admin@ldp412:~$ show log "SAI_SWITCH_ATTR_PACKET_TRIM_" 2025 Jul 31 01:24:26.140966 ldp412 NOTICE swss#orchagent: :- queryTrimDscpModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE) to query enum capabilities 2025 Jul 31 01:24:26.143248 ldp412 NOTICE swss#orchagent: :- queryTrimQueueModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE)enum value capabilities **Details if related** This is a follow up for sonic-net#3778

Backport to msft-202412, msft-202503, 202505  **What I did** Change the return code handling such that it does not produce an ERR level syslog in the case that SAI_STATUS_NOT_SUPPORTED is returned. Instead handle it gracefully. **Why I did it** Sonic seems to expect queryEnumCapabilitiesSai() to only be sucessful when it returns SAI_STATUS_SUCCESS. However, SAI_STATUS_NOT_SUPPORTED is also a valid return code if the attribute queried is not supported on a platform. **How I verified it** Verified that the new LOG messages are printed at NOTICE level rather than ERROR level. SONiC Software Version: SONiC.branch.202505-ars.ca6b34cb-buildimage.origin.202505-review.478334.1-2025.07.30.06.38 admin@ldp412:~$ show log "SAI_SWITCH_ATTR_PACKET_TRIM_" 2025 Jul 31 01:24:26.140966 ldp412 NOTICE swss#orchagent: :- queryTrimDscpModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE) to query enum capabilities 2025 Jul 31 01:24:26.143248 ldp412 NOTICE swss#orchagent: :- queryTrimQueueModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE)enum value capabilities **Details if related** This is a follow up for #3778

Backport to msft-202412, msft-202503, 202505  **What I did** Change the return code handling such that it does not produce an ERR level syslog in the case that SAI_STATUS_NOT_SUPPORTED is returned. Instead handle it gracefully. **Why I did it** Sonic seems to expect queryEnumCapabilitiesSai() to only be sucessful when it returns SAI_STATUS_SUCCESS. However, SAI_STATUS_NOT_SUPPORTED is also a valid return code if the attribute queried is not supported on a platform. **How I verified it** Verified that the new LOG messages are printed at NOTICE level rather than ERROR level. SONiC Software Version: SONiC.branch.202505-ars.ca6b34cb-buildimage.origin.202505-review.478334.1-2025.07.30.06.38 admin@ldp412:~$ show log "SAI_SWITCH_ATTR_PACKET_TRIM_" 2025 Jul 31 01:24:26.140966 ldp412 NOTICE swss#orchagent: :- queryTrimDscpModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE) to query enum capabilities 2025 Jul 31 01:24:26.143248 ldp412 NOTICE swss#orchagent: :- queryTrimQueueModeEnumCapabilities: Attribute not supported(SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE)enum value capabilities **Details if related** This is a follow up for sonic-net/sonic-swss#3778

justin-wong-ce requested a review from prsunny as a code owner July 22, 2025 17:15

justin-wong-ce closed this Jul 24, 2025

justin-wong-ce reopened this Jul 24, 2025

r12f reviewed Jul 29, 2025

View reviewed changes

Merge branch 'master' into enumQue

db544f6

kperumalbfn reviewed Jul 30, 2025

View reviewed changes

kperumalbfn requested a review from nazariig July 30, 2025 17:18

dhanasekar-arista mentioned this pull request Jul 31, 2025

Enhance return code handling for queryEnumCapabilitiesSai #3798

Merged

kperumalbfn approved these changes Jul 31, 2025

View reviewed changes

nazariig requested changes Aug 1, 2025

View reviewed changes

nazariig added Enhancement ➕ Request for msft-202412 Branch Request for 202505 Branch labels Aug 1, 2025

nazariig requested review from dgsudharsan and volodymyrsamotiy August 1, 2025 16:46

dhanasekar-arista mentioned this pull request Aug 5, 2025

Enhance return code handling for SAI_SWITCH_ATTR_PACKET_TRIM_QUEUE_RESOLUTION_MODE #3808

Merged

nazariig closed this Aug 5, 2025

mssonicbld mentioned this pull request Aug 5, 2025

[action] [PR:3798] Enhance return code handling for queryEnumCapabilitiesSai #3810

Merged

mssonicbld mentioned this pull request Aug 7, 2025

[action] [PR:3798] Enhance return code handling for queryEnumCapabilitiesSai Azure/sonic-swss.msft#124

Merged

mssonicbld mentioned this pull request Aug 12, 2025

[action] [PR:3798] Enhance return code handling for queryEnumCapabilitiesSai Azure/sonic-swss.msft#133

Merged

r12f removed Enhancement ➕ Request for msft-202412 Branch Request for 202505 Branch labels Feb 24, 2026

	"Attribute not supported(%s)enum value capabilities",
	"Attribute not supported(%s) to query enum value capabilities",

	"Attribute not supported(%s)enum value capabilities",
	"Attribute not supported(%s) to query attr vapabilities",

Conversation

justin-wong-ce commented Jul 22, 2025

Uh oh!

mssonicbld commented Jul 22, 2025

Uh oh!

azure-pipelines bot commented Jul 22, 2025

Uh oh!

mssonicbld commented Jul 24, 2025

Uh oh!

azure-pipelines bot commented Jul 24, 2025

Uh oh!

justin-wong-ce commented Jul 24, 2025

Uh oh!

mssonicbld commented Jul 24, 2025

Uh oh!

azure-pipelines bot commented Jul 24, 2025

Uh oh!

justin-wong-ce commented Jul 25, 2025

Uh oh!

mssonicbld commented Jul 25, 2025

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

dhanasekar-arista commented Jul 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jul 30, 2025

Uh oh!

azure-pipelines bot commented Jul 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kperumalbfn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants