[action] [PR:3594] [trim]: Add Packet Trimming to OA#3733
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jun 28, 2025
Merged
[action] [PR:3594] [trim]: Add Packet Trimming to OA#3733mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld merged 1 commit intosonic-net:202505from
Conversation
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-swss-common#1001 2. sonic-net/sonic-sairedis#1575 3. sonic-net/sonic-sairedis#1598 **HLD:** sonic-net/SONiC#1898 **What I did** * Implemented Packet Trimming feature **Why I did it** * Implementation is done according to the Packet Trimming HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
requested review from
bingwang-ms,
kperumalbfn and
prsunny
as code owners
Collaborator
Author
|
Original PR: #3594 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| ); | ||
| if (status != SAI_STATUS_SUCCESS) | ||
| { | ||
| SWSS_LOG_ERROR( |
Contributor
There was a problem hiding this comment.
@nazariig why is this an error ? is this feature supposed to be enabled/supported by default?
Collaborator
There was a problem hiding this comment.
@dhanasekar-arista the original assumption was that capabilities query call itself is always supported. Then vendor can provide more details on what exactly is not supported: either GET or SET or even both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
DEPENDS:
HLD: sonic-net/SONiC#1898
What I did
Why I did it
How I verified it
Details if related
A picture of a cute animal (not mandatory but encouraged)