[trim]: Add Packet Trimming Port/Queue stats to VS lib#1598
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Jun 3, 2025
Merged
[trim]: Add Packet Trimming Port/Queue stats to VS lib#1598kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
requested review from
dgsudharsan,
kcudnik,
kperumalbfn,
liat-grozovik,
moshemos and
volodymyrsamotiy
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
can you fix build errors? |
|
@nazariig Could you also fix the sairedis UT failures? |
nazariig
force-pushed
the
master-trim-stats
branch
from
ddaf6d8 to
385935c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-trim-stats
branch
from
385935c to
3455377
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
May 13, 2025
kcudnik
approved these changes
May 13, 2025
Collaborator
Author
|
@kcudnik looks like VS tests are unstable. Failures are not related to this change |
Collaborator
Author
|
Flaky tests: |
nazariig
force-pushed
the
master-trim-stats
branch
from
43a08b9 to
6dc07ff
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@kcudnik all is green. Ready to merge. |
Collaborator
Author
|
@kcudnik can you please help to merge? |
kcudnik
approved these changes
Jun 3, 2025
yejianquan
added
Approved for 202505 Branch
and removed
Approved for 202505 Branch
labels
Collaborator
|
Cherry-pick PR to 202505: #1608 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
Contributor
|
hi @nazariig , do you mind to help picking this PR to 202412? |
Collaborator
@r12f This is the 202412 PR Azure/sonic-sairedis.msft#60 |
Contributor
|
thanks Sud! updated tag for tracking |
r12f
added
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
Created PR to msft-202412 Branch
labels
mssonicbld
added a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jun 28, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-swss-common#1001 2. sonic-net/sonic-sairedis#1575 3. sonic-net/sonic-sairedis#1598 **HLD:** sonic-net/SONiC#1898 **What I did** * Implemented Packet Trimming feature **Why I did it** * Implementation is done according to the Packet Trimming HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jun 28, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-swss-common#1001 2. sonic-net/sonic-sairedis#1575 3. sonic-net/sonic-sairedis#1598 **HLD:** sonic-net/SONiC#1898 **What I did** * Implemented Packet Trimming feature **Why I did it** * Implementation is done according to the Packet Trimming HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
DEPENDS:
HLD: sonic-net/SONiC#1898
A picture of a cute animal (not mandatory but encouraged)