[action] [PR:3535] [swss]: IcmpOrch to support ICMP session offload to ASIC#3685
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jun 6, 2025
Merged
Conversation
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** IcmpOrch for supporting hardware offloaded ICMP echo sessions. Changes done here adds support for the SAI ICMP ECHO spec: https://github.com/opencomputeproject/SAI/blob/master/doc/SAI-Proposal-ICMP-ECHO.md A common template in saioffloadsession.h is added for handling sai offload sessions. BFD or any future offload session handling can be migrated to this template. IcmpOrch will create sessions based on switch capability published in STATE_DB by switchcorch which is checked in IcmpOrch's constructor. STATE_DB SWITCH_CAPABILITY: ``` "SWITCH_CAPABILITY|switch": { "value": { <snip> ... "ICMP_OFFLOAD_CAPABLE": "true", ... <snip> } }, ``` **Why I did it** ICMP echo sessions are used by LinkMgrd to monitor link state in Dual-ToR architecture and switch traffic. Current software based ICMP echo sessions used by Linkprober in LinkMgrd limits the detection time and uses host network bandwidth. Hardware based sessions will bring down the detection time and host network bandwidth is not used. **How I verified it** Tested the changes with DVS. **Details if related** ICMP echo table definitions: sonic-net/sonic-swss-common#980 ICMP echo SaiRedis changes: sonic-net/sonic-sairedis#1542
Collaborator
Author
|
Original PR: #3535 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,762 @@ | |||
| import pytest | |||
Check notice
Code scanning / CodeQL
Unused import Note test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
IcmpOrch for supporting hardware offloaded ICMP echo sessions.
Changes done here adds support for the SAI ICMP ECHO spec:
https://github.com/opencomputeproject/SAI/blob/master/doc/SAI-Proposal-ICMP-ECHO.md
A common template in saioffloadsession.h is added for handling sai offload sessions. BFD or any future offload session handling can be migrated to this template.
IcmpOrch will create sessions based on switch capability published in STATE_DB by switchcorch which is checked in IcmpOrch's constructor.
STATE_DB SWITCH_CAPABILITY:
Why I did it
ICMP echo sessions are used by LinkMgrd to monitor link state in Dual-ToR architecture and switch traffic.
Current software based ICMP echo sessions used by Linkprober in LinkMgrd limits the detection time and uses host network bandwidth.
Hardware based sessions will bring down the detection time and host network bandwidth is not used.
How I verified it
Tested the changes with DVS.
Details if related
ICMP echo table definitions: sonic-net/sonic-swss-common#980
ICMP echo SaiRedis changes: sonic-net/sonic-sairedis#1542