ICMP_ECHO_SESSION meta and notification layer changes#1542
Merged
kcudnik merged 1 commit intosonic-net:masterfrom May 5, 2025
Merged
ICMP_ECHO_SESSION meta and notification layer changes#1542kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Feb 27, 2025
kcudnik
requested changes
Feb 27, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
manamand2020
suggested changes
Mar 4, 2025
manamand2020
left a comment
manamand2020
left a comment
There was a problem hiding this comment.
Fix sai_serialize_icmp_echo_session_state_ntf()
harjotsinghpawra
force-pushed
the
master
branch
from
25bfc1b to
3b83a15
Compare
Collaborator
|
/azp run |
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1542 in repo sonic-net/sonic-sairedis |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
please resolve conflicts |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@kcudnik i made no changes in FlexCounter section. its failing for me even without my commit also. i see last commit in sonic-sairedis being merged having same failure . I have added all the test cases and in my previous run my code coverage was reaching 92%. I resynced my fork and raised new consolidated commit now i see all runs stuck and failing on this FlexCOunter.Bulksize test case with which my code is not related. Can you please help me review it again with added test case and help me to get it merged .thnaks for all you help |
Collaborator
|
that bulk test counter fail is also failing on master build, but only on ASAN build, other builds and tests are passing fine, can you rebase your changes to master and push force ? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@kcudnik Hi kamil , i rebased and only sonic-saireds and Asan build is failing with same bulksize error , rest of them are passing . Can you please review it and let me know if it looks good and we merge it . Thanks and Regards |
Collaborator
this is interesing why normal vstests is passing but with assan its failing hmm |
Contributor
Author
|
@kcudnik Hi kamil, i think you re-triggered the checks now everything is passing nice |
mssonicbld
added a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jun 6, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** IcmpOrch for supporting hardware offloaded ICMP echo sessions. Changes done here adds support for the SAI ICMP ECHO spec: https://github.com/opencomputeproject/SAI/blob/master/doc/SAI-Proposal-ICMP-ECHO.md A common template in saioffloadsession.h is added for handling sai offload sessions. BFD or any future offload session handling can be migrated to this template. IcmpOrch will create sessions based on switch capability published in STATE_DB by switchcorch which is checked in IcmpOrch's constructor. STATE_DB SWITCH_CAPABILITY: ``` "SWITCH_CAPABILITY|switch": { "value": { <snip> ... "ICMP_OFFLOAD_CAPABLE": "true", ... <snip> } }, ``` **Why I did it** ICMP echo sessions are used by LinkMgrd to monitor link state in Dual-ToR architecture and switch traffic. Current software based ICMP echo sessions used by Linkprober in LinkMgrd limits the detection time and uses host network bandwidth. Hardware based sessions will bring down the detection time and host network bandwidth is not used. **How I verified it** Tested the changes with DVS. **Details if related** ICMP echo table definitions: sonic-net/sonic-swss-common#980 ICMP echo SaiRedis changes: sonic-net/sonic-sairedis#1542
mssonicbld
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jun 6, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** IcmpOrch for supporting hardware offloaded ICMP echo sessions. Changes done here adds support for the SAI ICMP ECHO spec: https://github.com/opencomputeproject/SAI/blob/master/doc/SAI-Proposal-ICMP-ECHO.md A common template in saioffloadsession.h is added for handling sai offload sessions. BFD or any future offload session handling can be migrated to this template. IcmpOrch will create sessions based on switch capability published in STATE_DB by switchcorch which is checked in IcmpOrch's constructor. STATE_DB SWITCH_CAPABILITY: ``` "SWITCH_CAPABILITY|switch": { "value": { <snip> ... "ICMP_OFFLOAD_CAPABLE": "true", ... <snip> } }, ``` **Why I did it** ICMP echo sessions are used by LinkMgrd to monitor link state in Dual-ToR architecture and switch traffic. Current software based ICMP echo sessions used by Linkprober in LinkMgrd limits the detection time and uses host network bandwidth. Hardware based sessions will bring down the detection time and host network bandwidth is not used. **How I verified it** Tested the changes with DVS. **Details if related** ICMP echo table definitions: sonic-net/sonic-swss-common#980 ICMP echo SaiRedis changes: sonic-net/sonic-sairedis#1542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for ICMP_ECHO_SESSION in following areas of sonic-sairedis
meta layer
syncd
Notification Handling
added unittest to test notification and attribute handling