Skip to content

[neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prsunny merged 2 commits into from
Feb 12, 2025
Merged

[neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE #3478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5b5de
[neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE
bradh352 Jan 19, 2025
b6bd265
include linux/neighbor.h instead of pulling out define
bradh352 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion neighsyncd/neighsync.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "neighsync.h"
#include "warm_restart.h"
#include <algorithm>
#include <linux/neighbour.h>

using namespace std;
using namespace swss;
Expand Down Expand Up @@ -98,18 +99,28 @@ void NeighSync::onMsg(int nlmsg_type, struct nl_object *obj)
{
if ((isLinkLocalEnabled(intfName) == false) && (nlmsg_type != RTM_DELNEIGH))
{
SWSS_LOG_INFO("LinkLocal address received, ignoring for %s", ipStr);
return;
}
}
/* Ignore IPv6 multicast link-local addresses as neighbors */
if (family == IPV6_NAME && IN6_IS_ADDR_MC_LINKLOCAL(nl_addr_get_binary_addr(rtnl_neigh_get_dst(neigh))))
{
SWSS_LOG_INFO("Multicast LinkLocal address received, ignoring for %s", ipStr);
return;
}
key+= ipStr;

int state = rtnl_neigh_get_state(neigh);
if (state == NUD_NOARP)
{
return;
/* For externally learned neighbors, e.g. VXLAN EVPN, we want to keep
* these neighbors. */
if (!(rtnl_neigh_get_flags(neigh) & NTF_EXT_LEARNED))
{
SWSS_LOG_INFO("NOARP address received, ignoring for %s", ipStr);
return;
}
}

bool delete_key = false;
Expand Down
Loading