Skip to content

[neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE#3478

Merged
prsunny merged 2 commits intosonic-net:masterfrom
bradh352:bradh352/vxlan-evpn-neighbors
Feb 12, 2025
Merged

[neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE#3478
prsunny merged 2 commits intosonic-net:masterfrom
bradh352:bradh352/vxlan-evpn-neighbors

Conversation

@bradh352
Copy link
Copy Markdown
Contributor

@bradh352 bradh352 commented Jan 21, 2025

Why I did it

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue #3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The remote MAC-IP routes will be installed by BGP (Zebra) in Linux neighbor table against Vlan netdevice. Neighsyncd subscribes to neighbor entries and will receive remote MAC-IP bindings as well. These entries will continue to go into NEIGH_TABLE in APP_DB, and neighorch will update SAI database.

It appears this was mistakingly introduced in #943 with a short conversation here about the reason, but it didn't take into account other reasons for NOARP entries: https://github.com/sonic-net/sonic-swss/pull/943/files#r332867379

What I did

The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors (which have NOARP set).

How I verified it

Installed on a physical switch and observe remotely learned neighbors are present in NEIGH_TABLE

Details if related

Fixes #3384
Signed-off-by: Brad House (@bradh352)

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
@bradh352 bradh352 requested a review from prsunny as a code owner January 21, 2025 22:57
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 changed the title [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE [neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE Jan 21, 2025
bradh352 added a commit to bradh352/sonic-swss that referenced this pull request Jan 21, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
bradh352 added a commit to bradh352/sonic-swss that referenced this pull request Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
bradh352 added a commit to bradh352/sonic-swss that referenced this pull request Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jan 23, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
@bradh352
Copy link
Copy Markdown
Contributor Author

@srj102 @dgsudharsan @prsunny mind taking a look at this PR to fix the NEIGH_TABLE entries for EVPN VXLAN?

github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jan 29, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jan 30, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jan 31, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 1, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 3, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 4, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 5, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 6, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 7, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 8, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
@bradh352
Copy link
Copy Markdown
Contributor Author

@srj102 @dgsudharsan @prsunny ping. This is a fix for a regression.

@srj102
Copy link
Copy Markdown
Contributor

srj102 commented Feb 10, 2025

@LaveenBrcm Could you please check this ?

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Feb 12, 2025

@srj102, @dgsudharsan for viz

@prsunny prsunny merged commit 7410b89 into sonic-net:master Feb 12, 2025
15 checks passed
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 13, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 14, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 15, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Feb 19, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling

The reason it was not occurring is NOARP entries were being rejected, this
patch adds an exception for externally learned neighbors.

Signed-off-by: Brad House (@bradh352)
andrewsapronov pushed a commit to netbergtw/sonic-swss that referenced this pull request Mar 12, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
andrewsapronov pushed a commit to netbergtw/sonic-swss that referenced this pull request Apr 22, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
bluecmd pushed a commit to kamelnetworks/sonic-swss that referenced this pull request May 3, 2025
* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
bradh352 added a commit to bradh352/sonic-swss that referenced this pull request Jun 9, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Jun 12, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
dal00 pushed a commit to kamelnetworks/sonic-swss that referenced this pull request Jul 20, 2025
* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Aug 6, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Nov 18, 2025
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request Feb 23, 2026
)

* [neighsync] VXLAN EVPN neighbors not in NEIGH_TABLE

VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per
Issue sonic-net#3384.

The EVPN VXLAN HLD specifically states this should be populated so it triggers
an update to the SAI database:

https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEIGH_TABLE not populated with VXLAN routes

4 participants