Fix the Orchagent Qos error messages reported in Issue #16787#2947
Merged
prsunny merged 6 commits intosonic-net:masterfrom Nov 21, 2023
Merged
Fix the Orchagent Qos error messages reported in Issue #16787#2947prsunny merged 6 commits intosonic-net:masterfrom
prsunny merged 6 commits intosonic-net:masterfrom
Conversation
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Contributor
Author
|
@vmittal-msft , please review this |
vmittal-msft
reviewed
Nov 4, 2023
orchagent/bufferorch.cpp
Outdated
| } | ||
|
|
||
| if(tokens[0] == gMyHostName) | ||
| if((tokens[0] == gMyHostName) & (tokens[1] == gMyAsicName)) |
Contributor
There was a problem hiding this comment.
Shouldn't this be -
if((tokens[0] == gMyHostName) && (tokens[1] == gMyAsicName))
vmittal-msft
reviewed
Nov 4, 2023
orchagent/qosorch.cpp
Outdated
| } | ||
|
|
||
| if(tokens[0] == gMyHostName) | ||
| if((tokens[0] == gMyHostName) & (tokens[1] == gMyAsicName)) |
Contributor
There was a problem hiding this comment.
Shouldn't this be -
if((tokens[0] == gMyHostName) && (tokens[1] == gMyAsicName))
Contributor
Author
There was a problem hiding this comment.
It was typo and fixed it now.
*Orchagent send heartbeat during warm-reboot to prevent Orchagent stuck alert.
gechiang
approved these changes
Nov 17, 2023
vmittal-msft
approved these changes
Nov 18, 2023
prsunny
approved these changes
Nov 18, 2023
Contributor
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…net#2947) * Fix the Orchagent Qos error messages reported in Issue #16787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added a Asic name check in addition to Host name check to determine if the system port is local system port or remote system port to fix the errors reported in Issue #16787 which were introduced by sonic-swss PR #2855
Why I did it
Error messages were seen with sonic-swss PR #2855 and added this fix to address the error messages and to apply the Qos config correctly.
How I verified it
Loaded the image in the Chassis and verified that the error messages are not seen in the syslog message.
Details if related