Skip to content

[Chassis][202205][orchagent] : Support WRED profiles on system ports#2945

Merged
prsunny merged 2 commits intosonic-net:202205from
vmittal-msft:vmittal/wred_profile
Nov 28, 2023
Merged

[Chassis][202205][orchagent] : Support WRED profiles on system ports#2945
prsunny merged 2 commits intosonic-net:202205from
vmittal-msft:vmittal/wred_profile

Conversation

@vmittal-msft
Copy link
Copy Markdown
Contributor

MSFT ADO: 24595422

What I did
Added support to apply wred profile on system ports

Why I did it
remote system ports were missing wred profile

How I verified it
Tested on sonic chassis

Details if related

@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Oct 26, 2023

Porting of
#2855 + #2947 + #2954

@vmittal-msft
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 2945 in repo sonic-net/sonic-swss

@gechiang
Copy link
Copy Markdown
Contributor

/Azurepipelines run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 2945 in repo sonic-net/sonic-swss

@vmittal-msft vmittal-msft force-pushed the vmittal/wred_profile branch 2 times, most recently from d09076b to f5d2be8 Compare November 27, 2023 20:32
@vmittal-msft vmittal-msft requested a review from rlhui November 27, 2023 21:35
Copy link
Copy Markdown
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gechiang
Copy link
Copy Markdown
Contributor

@yxieca , @prsunny , @StormLiangMS , This is the PR that included the original fix (PR: #2855) that got merged to master but was not allowed for 202211, 202305 and 202205 due to missing required unit testcases +
the missing PR unit test (#2954 (review)) +
a needed fix already merged in master (#2947) that is needed also in other branches .

The idea is having this combined one single PR to be approved/merged in 202205 and then use it to cherry-pick into the other 2 branches which should reduce the potential cherry-pick conflict.

Thanks!

@vmittal-msft vmittal-msft changed the title [Chassis][orchagent] : Support WRED profiles on system ports [Chassis][202205][orchagent] : Support WRED profiles on system ports Nov 28, 2023
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Nov 28, 2023

@yxieca for viz

@prsunny prsunny merged commit fbab6b7 into sonic-net:202205 Nov 28, 2023
@vmittal-msft vmittal-msft deleted the vmittal/wred_profile branch November 28, 2023 18:36
@gechiang
Copy link
Copy Markdown
Contributor

@vmittal-msft can you run on a pizzabox with this change in 202305 based code to ensure it will not cause regression before Storm pick this up into 2002305.
Thanks!

@gechiang
Copy link
Copy Markdown
Contributor

@vmittal-msft do we really need this for 202211? if not, let's remove the label.

@StormLiangMS
Copy link
Copy Markdown
Contributor

@gechiang @vmittal-msft remind for test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants