Add support for fabric monitor daemon (swss part).

[jfeng-arista]

Add support for fabric monitor daemon ( swss related changes )

Added fabricmgr that reacts the change in config_db and writes to appl_db, as orchagent can only reacts to the appl_db changes in current infrastructure.

So, when users configure the fabric link monitoring polling period or threshold to a none default values, the cli changes the value in config_db. This fabricmgr will react to the change in config_db and copy the value to appl_db. The fabric orchagent can react to the appl_db change and adjust the algorithm accordingly.

need to merge sonic-net/sonic-sairedis#1301 and sonic-net/sonic-buildimage#16791 first for test.

What I did

Why I did it

How I verified it

Details if related

[jfeng-arista]

/azpw run Azure.sonic-swss

[mssonicbld]

/AzurePipelines run Azure.sonic-swss

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jfeng-arista]

this depends on sonic-net/sonic-swss-common#808 . we need submodule update .

[prsunny]

@arlakshm , please review

[prsunny]

Please add unit-tests

[jfeng-arista]

sonic-net/sonic-sairedis#1301 is the preparation for adding tests for this PR

[jfeng-arista]

For running the test, we need to merge
sonic-net/sonic-sairedis#1301 and
sonic-net/sonic-buildimage#16791

[jfeng-arista]

the vs test failures needs
sonic-net/sonic-sairedis#1301
and
sonic-net/sonic-buildimage#16791
merge first

[prsunny]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jfeng-arista]

sonic-net/sonic-sairedis#1301 merged in on Sun, Oct 8
now we need to wait sonic-net/sonic-buildimage#16791   to run the stest.
 

[arlakshm]

/Azp run Azure.sonic-swss

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[arlakshm]

Hi @jfeng-arista sonic-net/sonic-buildimage#16791 is merged now. Can you help update the branch.

[saksarav-nokia]

@jfeng-arista , I am adding the fabric monitoring device files for nokia platform and i am trying to understand the lanes field in the fabric_port_config.ini file. Does this need to match to the SAI_PORT_ATTR_HW_LANE_LIST returned by SAI for the fabric port?.
Could please confirm?

name lanes isolateStatus

Fabric0 0 False
Fabric1 1 False
Fabric2 2 False
Fabric3 3 False
Fabric4 4 False
Fabric5 5 False

Thanks,
Sakthi

[jfeng-arista]

test_drop_counters.py:762:

---

self = <test_drop_counters.TestDropCounters object at 0x7f3a31c208e0>
stats = ['SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_0_DROPPED_PKTS', 'SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS']
counter_list_type = 'PORT_DEBUG_COUNTER_ID_LIST'

def checkFlexState(self, stats, counter_list_type):
    flex_counter_table = swsscommon.Table(self.flex_db, FLEX_COUNTER_TABLE)

    for oid in flex_counter_table.getKeys():
        attributes = self.genericGetAndAssert(flex_counter_table, oid)
        assert len(attributes) == 1
        field, tracked_stats = attributes[0]
        assert field == counter_list_type
        for stat in stats:

          assert stat in tracked_stats

E AssertionError: assert 'SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS' in 'SAI_PORT_STAT_OUT_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS,SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_0_DROPPED_PKTS'

test_drop_counters.py:109: AssertionError

this is the new test failure, not seems related to this change, will try trigger the test pipeline again

[jfeng-arista]

test_drop_counters.py:762:

---

self = <test_drop_counters.TestDropCounters object at 0x7fd196394a00>
stats = ['SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_0_DROPPED_PKTS', 'SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS']
counter_list_type = 'PORT_DEBUG_COUNTER_ID_LIST'

def checkFlexState(self, stats, counter_list_type):
    flex_counter_table = swsscommon.Table(self.flex_db, FLEX_COUNTER_TABLE)

    for oid in flex_counter_table.getKeys():
        attributes = self.genericGetAndAssert(flex_counter_table, oid)
        assert len(attributes) == 1
        field, tracked_stats = attributes[0]
        assert field == counter_list_type
        for stat in stats:

          assert stat in tracked_stats

E AssertionError: assert 'SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS' in 'SAI_PORT_STAT_OUT_CONFIGURED_DROP_REASONS_1_DROPPED_PKTS,SAI_PORT_STAT_IN_CONFIGURED_DROP_REASONS_0_DROPPED_PKTS'

test_drop_counters.py:109: AssertionError

[jfeng-arista]

/azpw run Azure.sonic-swss

[mssonicbld]

/AzurePipelines run Azure.sonic-swss

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jfeng-arista]

Now all tests passed

[arlakshm]

@prsunny, please help merge this PR

[prsunny]

@jfeng-arista , @arlakshm , could you please confirm all dependent PRs are merged and this is ready for merge?

[jfeng-arista]

@jfeng-arista , @arlakshm , could you please confirm all dependent PRs are merge and this is ready for merge?

Yes. thank you