Add fabric monitoring tables definitions. by jfeng-arista · Pull Request #808 · sonic-net/sonic-swss-common

jfeng-arista · 2023-07-28T21:14:35Z

Add fabric monitoring table names in a common location, as they are utilized in multiple files associated with the fabric monitoring feature.

places.

jfeng-arista · 2023-07-31T02:00:18Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-07-31T02:00:20Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-07-31T02:00:32Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-07-31T03:08:15Z

The failure was

2023-07-28T22:55:52.2381925Z ==================================== ERRORS ====================================
2023-07-28T22:55:52.2382365Z ___________ ERROR at setup of TestAcl.test_AclTableCreationDeletion ____________
2023-07-28T22:55:52.2382548Z
2023-07-28T22:55:52.2383106Z tp = <class 'AssertionError'>, value = None, tb = None
2023-07-28T22:55:52.2383225Z
2023-07-28T22:55:52.2387164Z def reraise(tp, value, tb=None):
2023-07-28T22:55:52.2387402Z try:
2023-07-28T22:55:52.2387618Z if value is None:
2023-07-28T22:55:52.2387832Z value = tp()
2023-07-28T22:55:52.2388083Z if value.traceback is not tb:
2023-07-28T22:55:52.2388615Z > raise value.with_traceback(tb)

arlakshm · 2023-07-31T21:20:38Z

/Azp Azure.sonic-swss-common

azure-pipelines · 2023-07-31T21:20:43Z

Command 'Azure.sonic-swss-common' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

jfeng-arista · 2023-08-01T21:19:56Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-08-01T21:19:58Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-08-01T21:20:09Z

Azure Pipelines successfully started running 1 pipeline(s).

common/schema.h

jfeng-arista · 2023-08-14T22:36:37Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-08-14T22:36:38Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-08-14T22:36:49Z

Azure Pipelines successfully started running 1 pipeline(s).

rlhui · 2023-08-18T04:07:56Z

Is this a code refactoring only or it's to actually fix any bug? Thanks.

jfeng-arista · 2023-08-18T04:13:49Z

These are the table defination for fabric link monitoring feature, the other code will depend on these tables

jfeng-arista · 2023-08-22T20:55:21Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-08-22T20:55:23Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-08-22T20:55:34Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-08-22T22:00:39Z

it failed with

In file included from dash/dashaclorch.h:19,
from orchdaemon.h:49,
from main.cpp:25:
dash/dashorch.h:21:10: fatal error: dash_api/appliance.pb.h: No such file or directory
21 | #include "dash_api/appliance.pb.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

It seems not related to this change

jfeng-arista · 2023-08-22T23:34:00Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-08-22T23:34:02Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-08-22T23:34:12Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-08-23T05:41:13Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-08-23T05:41:15Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-08-23T05:41:25Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-18T21:16:31Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-18T21:16:34Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-18T21:16:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-20T15:20:15Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-20T15:20:17Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-20T15:20:30Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-20T18:13:50Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-20T18:13:53Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-20T18:14:05Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-20T19:39:05Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-20T19:39:08Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-20T19:39:24Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-20T23:03:54Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-20T23:03:56Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-20T23:04:08Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-20T23:31:50Z

test_NeighborAddRemoveIpv6LinkLocal failed (1 runs remaining out of 2).
<class 'AssertionError'>
assert 3 == 4
-3
+4
it looks like not related to this change

jfeng-arista · 2023-09-21T00:37:24Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-21T00:37:26Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-21T00:37:37Z

Azure Pipelines successfully started running 1 pipeline(s).

jfeng-arista · 2023-09-21T05:36:37Z

test_NeighborAddRemoveIpv6LinkLocal failed (1 runs remaining out of 2).
<class 'AssertionError'>
assert 3 == 4
-3
+4
[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_ipv6_link_local.py:63>]

The failure not related to this change

jfeng-arista · 2023-09-22T17:16:21Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2023-09-22T17:16:23Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2023-09-22T17:16:35Z

Azure Pipelines successfully started running 1 pipeline(s).

Add fabric monitoring tables defination here as they are used in several

0ef8afe

places.

jfeng-arista mentioned this pull request Jul 31, 2023

Update fabric link monitoring plan. sonic-net/SONiC#1013

Merged

qiluo-msft reviewed Aug 4, 2023

View reviewed changes

common/schema.h Outdated Show resolved Hide resolved

rlhui assigned jfeng-arista Aug 9, 2023

Merge branch 'master' into master-add-fabric-monitor-tables

d4474d9

Merge branch 'master' into master-add-fabric-monitor-tables

9f5f542

Merge branch 'master' into master-add-fabric-monitor-tables

198c245

Rename the tables in APPL_DB.

0570bd0

jfeng-arista dismissed arlakshm’s stale review via 0570bd0 September 20, 2023 19:12

qiluo-msft approved these changes Sep 20, 2023

View reviewed changes

arlakshm approved these changes Sep 25, 2023

View reviewed changes

arlakshm merged commit b0f148e into sonic-net:master Sep 25, 2023

jfeng-arista mentioned this pull request Oct 2, 2023

Add support for fabric monitor daemon (swss part). sonic-net/sonic-swss#2920

Merged

Conversation

jfeng-arista commented Jul 28, 2023

Uh oh!

jfeng-arista commented Jul 31, 2023

Uh oh!

mssonicbld commented Jul 31, 2023

Uh oh!

azure-pipelines bot commented Jul 31, 2023

Uh oh!

jfeng-arista commented Jul 31, 2023

Uh oh!

arlakshm commented Jul 31, 2023

Uh oh!

azure-pipelines bot commented Jul 31, 2023

Uh oh!

jfeng-arista commented Aug 1, 2023

Uh oh!

mssonicbld commented Aug 1, 2023

Uh oh!

azure-pipelines bot commented Aug 1, 2023

Uh oh!

Uh oh!

jfeng-arista commented Aug 14, 2023

Uh oh!

mssonicbld commented Aug 14, 2023

Uh oh!

azure-pipelines bot commented Aug 14, 2023

Uh oh!

rlhui commented Aug 18, 2023

Uh oh!

jfeng-arista commented Aug 18, 2023

Uh oh!

jfeng-arista commented Aug 22, 2023

Uh oh!

mssonicbld commented Aug 22, 2023

Uh oh!

azure-pipelines bot commented Aug 22, 2023

Uh oh!

jfeng-arista commented Aug 22, 2023

Uh oh!

jfeng-arista commented Aug 22, 2023

Uh oh!

mssonicbld commented Aug 22, 2023

Uh oh!

azure-pipelines bot commented Aug 22, 2023

Uh oh!

jfeng-arista commented Aug 23, 2023

Uh oh!

mssonicbld commented Aug 23, 2023

Uh oh!

azure-pipelines bot commented Aug 23, 2023

Uh oh!

jfeng-arista commented Sep 18, 2023

Uh oh!

mssonicbld commented Sep 18, 2023

Uh oh!

azure-pipelines bot commented Sep 18, 2023

Uh oh!

jfeng-arista commented Sep 20, 2023

Uh oh!

mssonicbld commented Sep 20, 2023

Uh oh!

azure-pipelines bot commented Sep 20, 2023

Uh oh!

jfeng-arista commented Sep 20, 2023

Uh oh!

mssonicbld commented Sep 20, 2023

Uh oh!

azure-pipelines bot commented Sep 20, 2023

Uh oh!

jfeng-arista commented Sep 20, 2023

Uh oh!

mssonicbld commented Sep 20, 2023

Uh oh!

azure-pipelines bot commented Sep 20, 2023

Uh oh!

jfeng-arista commented Sep 20, 2023

Uh oh!

mssonicbld commented Sep 20, 2023

Uh oh!