Skip to content

[202211][CodeQL]: Use dependencies with relevant versions in azp template#2843

Merged
qiluo-msft merged 1 commit intosonic-net:202211from
nazariig:202211-codeql-infra-fix
Jul 12, 2023
Merged

[202211][CodeQL]: Use dependencies with relevant versions in azp template#2843
qiluo-msft merged 1 commit intosonic-net:202211from
nazariig:202211-codeql-infra-fix

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

@nazariig nazariig commented Jul 4, 2023

Signed-off-by: Nazarii Hnydyn [email protected]

What I did

  • Increase robustness of CodeQL: use only dependencies with the relevant versions

Why I did it

  • To fix CodeQL compilation failures

How I verified it

  1. Make a PR
  2. Do a push

Details if related

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 5, 2023

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 5, 2023

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 6, 2023

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 6, 2023

@qiluo-msft / @prsunny would you please help to merge?

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 7, 2023

@qiluo-msft / @prsunny this is a blocker for Port Profile Init feature. Would you please help to merge?

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Jul 7, 2023

@nazariig , is there a master branch PR for reference?
@liushilongbuaa and @xumia to signoff and merge
@StormLiangMS, @yxieca for viz

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Jul 7, 2023

@nazariig , is there a master branch PR for reference? @liushilongbuaa and @xumia to signoff and merge @StormLiangMS, @yxieca for viz

@prsunny i have extended the description

@nazariig
Copy link
Copy Markdown
Collaborator Author

@liushilongbuaa / @xumia just a kind reminder

@nazariig
Copy link
Copy Markdown
Collaborator Author

@prsunny can you please merge this one too?

@liushilongbuaa
Copy link
Copy Markdown
Contributor

image
It seems good from CodeQL in master branch.

Copy link
Copy Markdown
Contributor

@liushilongbuaa liushilongbuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nazariig
Copy link
Copy Markdown
Collaborator Author

@prsunny / @qiluo-msft just a kind reminder

@nazariig nazariig force-pushed the 202211-codeql-infra-fix branch from b95e298 to cd4be22 Compare July 12, 2023 14:39
@qiluo-msft qiluo-msft merged commit eff2b75 into sonic-net:202211 Jul 12, 2023
@nazariig nazariig requested a review from yxieca September 18, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants