[202211][ppi]: Implement port bulk comparison logic (#2564) #2821
Merged
liat-grozovik merged 6 commits intosonic-net:202211from Jul 23, 2023
Merged
[202211][ppi]: Implement port bulk comparison logic (#2564) #2821liat-grozovik merged 6 commits intosonic-net:202211from
liat-grozovik merged 6 commits intosonic-net:202211from
Conversation
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@saiarcot895 as this is backport for a PR you approved on master, can you please review this as well? |
Collaborator
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
reviewed
Jul 5, 2023
| #undef private | ||
| #define private public | ||
| #include "warm_restart.h" | ||
| #undef private |
Contributor
There was a problem hiding this comment.
Rather than doing this hack, can friendship declarations be used instead?
saiarcot895
approved these changes
Jul 5, 2023
Contributor
saiarcot895
left a comment
saiarcot895
left a comment
There was a problem hiding this comment.
Approved with a comment.
10 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 12, 2023
…late. (#2843) **What I did** * Increase robustness of `CodeQL`: use only dependencies with the relevant versions **Why I did it** * To fix `CodeQL` compilation failures **How I verified it** 1. Make a PR 2. Do a push **Details if related** * Backport from `master`: #2845 * Resolves checker issue: #2821 * Takes effect only after PR is merged
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
prgeor
approved these changes
Jul 14, 2023
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
LGTM.
@nazariig @liat-grozovik please attach the test results for the manual test done to verify AN/LT,FEC, port breakout
Signed-off-by: Nazarii Hnydyn <[email protected]>
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Jul 23, 2023
Collaborator
|
/azp run EasyCLA |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
liat-grozovik
changed the title
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 25, 2023
DEPENDS: [202211][ppi]: Implement port bulk comparison logic (#2564) #2821 HLD: sonic-net/SONiC#1084 What I did Removed unused code Why I did it To complete code cleanup How I verified it UT tests VS tests Details if related Backport from master: [ppi]: General code cleanup: remove unused methods #2867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
DEPENDS:
HLD: sonic-net/SONiC#1084
What I did
Why I did it
How I verified it
Details if related
master: [ppi]: Implement port bulk comparison logic #2564