Remove counters for Mux ACL#2650
Merged
kevinskwang merged 1 commit intosonic-net:202205from Feb 2, 2023
devpatha:202205
Merged
Remove counters for Mux ACL#2650kevinskwang merged 1 commit intosonic-net:202205from devpatha:202205
kevinskwang merged 1 commit intosonic-net:202205from
devpatha:202205
Conversation
kevinskwang
approved these changes
Feb 2, 2023
Contributor
|
@kevinskwang please use squash and merge going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Do not use counters for mux ACL
Why I did it
Noticed that with PR #1982 counters are enabled by default. It was not the case earlier.
User won't be able to see it with aclshow and it will waste valuable hardware counter resource.
How I verified it
Details if related
Master PR: #2643