Skip to content

Remove counters for Mux ACL#2643

Merged
kevinskwang merged 1 commit intosonic-net:masterfrom
devpatha:master
Mar 31, 2023
Merged

Remove counters for Mux ACL#2643
kevinskwang merged 1 commit intosonic-net:masterfrom
devpatha:master

Conversation

@devpatha
Copy link
Copy Markdown
Contributor

What I did
Do not use counters for mux ACL

Why I did it
Noticed that with PR #1982 counters are enabled by default. It was not the case earlier.
User won't be able to see it with aclshow and it will waste valuable hardware counter resource.

How I verified it

Details if related

@devpatha devpatha requested a review from prsunny as a code owner January 26, 2023 01:54
@bingwang-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kevinskwang
Copy link
Copy Markdown

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@devpatha
Copy link
Copy Markdown
Contributor Author

devpatha commented Mar 6, 2023

@bingwang-ms could we please re-run checks here? This has already been merged into 202205 and would like to be there in master as well.

@kevinskwang
Copy link
Copy Markdown

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca
Copy link
Copy Markdown
Contributor

yxieca commented Apr 1, 2023

#1982 was only committed to master branch. @StormLiangMS please check if it was included in 202211 branch. From merge time of #1982, it might have been included in 202211 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants