[CoPP] Add always_enabled field to coppmgr logic#2147
Merged
prsunny merged 1 commit intosonic-net:202012from Feb 23, 2022
Merged
[CoPP] Add always_enabled field to coppmgr logic#2147prsunny merged 1 commit intosonic-net:202012from
prsunny merged 1 commit intosonic-net:202012from
Conversation
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
|
This pull request introduces 2 alerts when merging bb833c4 into 081dd01 - view on LGTM.com new alerts:
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Isn't this dependent on sonic-net/sonic-buildimage#9999 ? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Feb 23, 2022
Collaborator
|
@noaOrMlnx , could you please raise a submodule update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.
Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.
How I verified it
run tests for making sure traps are installed and not when expecting them to.
Details if related
Related to sonic-buildimage change - [CoPP] Add always_enabled field sonic-buildimage#9302
SONiC mgmt test plan can be found in Copp manager redesign test plan SONiC#903.
This commit is a cherry-pick of #2034