[CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss

noaOrMlnx · 2021-11-18T09:03:13Z

What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

How I verified it
run tests for making sure traps are installed and not when expecting them to.

Details if related
related to sonic-buildimage change - sonic-net/sonic-buildimage#9302

SONiC mgmt test plan can be found in sonic-net/SONiC#903.

noaOrMlnx · 2021-11-18T09:28:36Z

/azpw run

mssonicbld · 2021-11-18T09:28:38Z

/AzurePipelines run

azure-pipelines · 2021-11-18T09:28:50Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2021-11-18T09:36:18Z

/azpw run

mssonicbld · 2021-11-18T09:36:20Z

/AzurePipelines run

azure-pipelines · 2021-11-18T09:36:30Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2021-11-18T11:10:31Z

/azpw run

mssonicbld · 2021-11-18T11:10:32Z

/AzurePipelines run

azure-pipelines · 2021-11-18T11:10:47Z

Azure Pipelines successfully started running 1 pipeline(s).

…always_enabled_field

noaOrMlnx · 2021-11-22T15:43:36Z

/azpw run

mssonicbld · 2021-11-22T15:43:38Z

/AzurePipelines run

azure-pipelines · 2021-11-22T15:43:48Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2021-11-24T09:35:45Z

/azpw run

mssonicbld · 2021-11-24T09:35:46Z

/AzurePipelines run

azure-pipelines · 2021-11-24T09:35:56Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2021-11-30T07:47:15Z

/azpw run

mssonicbld · 2021-11-30T07:47:16Z

/AzurePipelines run

azure-pipelines · 2021-11-30T07:47:27Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-11-30T19:04:56Z

/azp run

azure-pipelines · 2021-11-30T19:05:07Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2021-12-01T08:59:26Z

/azpw run

mssonicbld · 2021-12-01T08:59:45Z

/AzurePipelines run

azure-pipelines · 2021-12-01T08:59:57Z

Azure Pipelines successfully started running 1 pipeline(s).

Change the assertion logic to be correct

azure-pipelines · 2022-01-16T06:27:23Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-01-18T20:14:47Z

/azp run Azure.sonic-swss

azure-pipelines · 2022-01-18T20:15:01Z

Azure Pipelines successfully started running 1 pipeline(s).

…always_enabled_field

noaOrMlnx · 2022-01-24T15:22:08Z

/azpw run

mssonicbld · 2022-01-24T15:22:10Z

/AzurePipelines run

azure-pipelines · 2022-01-24T15:22:23Z

Azure Pipelines successfully started running 1 pipeline(s).

noaOrMlnx · 2022-01-25T11:24:47Z

/azpw run

mssonicbld · 2022-01-25T11:24:49Z

/AzurePipelines run

azure-pipelines · 2022-01-25T11:25:00Z

Azure Pipelines successfully started running 1 pipeline(s).

- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.

qiluo-msft · 2022-01-31T20:15:41Z

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

prsunny · 2022-02-11T01:57:29Z

@noaOrMlnx , can you please raise a new PR for 202012?

- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.

- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.

[CoPP] Add always_enabled field to coppmgr logic

10804d7

noaOrMlnx requested a review from prsunny as a code owner November 18, 2021 09:03

dgsudharsan previously approved these changes Nov 22, 2021

View reviewed changes

Merge branch 'master' of github.com:Azure/sonic-swss into noaor_copp_…

f75457b

…always_enabled_field

prsunny previously approved these changes Nov 22, 2021

View reviewed changes

Update test_disabled_feature_always_enabled_trap

e32c891

Change the assertion logic to be correct

noaOrMlnx dismissed prsunny’s stale review via e32c891 December 2, 2021 12:20

Merge branch 'master' of github.com:Azure/sonic-swss into noaor_copp_…

91d2d5a

…always_enabled_field

JibinBao mentioned this pull request Jan 26, 2022

Add tests for copp manager redesign sonic-net/sonic-mgmt#4891

Merged

4 tasks

liat-grozovik approved these changes Jan 26, 2022

View reviewed changes

liat-grozovik merged commit 53c630b into sonic-net:master Jan 26, 2022

liat-grozovik removed the Request for 202106 Branch label Jan 26, 2022

noaOrMlnx mentioned this pull request Jan 26, 2022

[submodule] Update sonic-swss submodule pointer sonic-net/sonic-buildimage#9859

Merged

5 tasks

judyjoseph added the Included in 202111 Branch label Jan 31, 2022

neethajohn mentioned this pull request Feb 9, 2022

Investigate/fix copp test failures on backend T0/T1 sonic-net/sonic-mgmt#5106

Closed

qiluo-msft removed the Request for 202012 Branch label Feb 16, 2022

noaOrMlnx mentioned this pull request Feb 16, 2022

[CoPP] Add always_enabled field to coppmgr logic #2147

Merged

JibinBao mentioned this pull request Feb 17, 2022

Copp manager redesign test plan sonic-net/SONiC#903

Merged

prsunny pushed a commit that referenced this pull request Feb 23, 2022

[CoPP] Add always_enabled field to coppmgr logic (#2034) (#2147)

6ac0b9b

- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file.

This was referenced Mar 14, 2022

Update CoPP design with always_enabled field info noaOrMlnx/SONiC#4

Closed

Update CoPP design with new always_enabled field info sonic-net/SONiC#962

Merged

ZhaohuiS mentioned this pull request Feb 1, 2023

Skip test_trap_config_save_after_reboot for 202012 branch sonic-net/sonic-mgmt#7373

Merged

6 tasks

Conversation

noaOrMlnx commented Nov 18, 2021 • edited by liat-grozovik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noaOrMlnx commented Nov 18, 2021

Uh oh!

mssonicbld commented Nov 18, 2021

Uh oh!

azure-pipelines bot commented Nov 18, 2021

Uh oh!

noaOrMlnx commented Nov 18, 2021

Uh oh!

mssonicbld commented Nov 18, 2021

Uh oh!

azure-pipelines bot commented Nov 18, 2021

Uh oh!

noaOrMlnx commented Nov 18, 2021

Uh oh!

mssonicbld commented Nov 18, 2021

Uh oh!

azure-pipelines bot commented Nov 18, 2021

Uh oh!

noaOrMlnx commented Nov 22, 2021

Uh oh!

mssonicbld commented Nov 22, 2021

Uh oh!

azure-pipelines bot commented Nov 22, 2021

Uh oh!

noaOrMlnx commented Nov 24, 2021

Uh oh!

mssonicbld commented Nov 24, 2021

Uh oh!

azure-pipelines bot commented Nov 24, 2021

Uh oh!

noaOrMlnx commented Nov 30, 2021

Uh oh!

mssonicbld commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

prsunny commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

noaOrMlnx commented Dec 1, 2021

Uh oh!

mssonicbld commented Dec 1, 2021

Uh oh!

azure-pipelines bot commented Dec 1, 2021

Uh oh!

azure-pipelines bot commented Jan 16, 2022

Uh oh!

liat-grozovik commented Jan 18, 2022

Uh oh!

azure-pipelines bot commented Jan 18, 2022

Uh oh!

noaOrMlnx commented Jan 24, 2022

Uh oh!

mssonicbld commented Jan 24, 2022

Uh oh!

azure-pipelines bot commented Jan 24, 2022

Uh oh!

noaOrMlnx commented Jan 25, 2022

Uh oh!

mssonicbld commented Jan 25, 2022

Uh oh!

azure-pipelines bot commented Jan 25, 2022

Uh oh!

qiluo-msft commented Jan 31, 2022

Uh oh!

prsunny commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

noaOrMlnx commented Nov 18, 2021 •

edited by liat-grozovik

Loading