ASIC internal temperature sensors support#1517
Conversation
|
vs build failed due to missing dependency, sonic-net/sonic-swss-common#419 |
ASIC internal temperature sensors support More details: sonic-net/sonic-swss#1517 Details if related HLD Location: https://github.com/Azure/SONiC/blob/master/doc/asic_thermal_monitoring_hld.md
|
sonic-net/sonic-swss-common#419 has merged. Submodule update PR is here: sonic-net/sonic-buildimage#6042 |
|
retest this please |
1 similar comment
|
retest this please |
|
retest LGTM please |
|
retest this please |
1 similar comment
|
retest this please |
|
LGTM. @kcudnik to review, as well. |
prsunny
left a comment
There was a problem hiding this comment.
Should we add VS tests?
|
retest this please |
kcudnik
left a comment
There was a problem hiding this comment.
please wait for others to approve
|
@keboliu Please review. |
|
@santhosh-kt: All reviewers have signed off and sonic-net/sonic-swss-common#419 has been merged and the submodule has been updated to include that commit. Are we good to merge this now? |
|
@jleveque : Please proceed to merge and update the submodule. |
|
@jleveque : This PR is yet to get update in the submodule. |
|
@santhosh-kt: Please feel free to open a PR to update the sonic-swss submodule in sonic-buildimage. |
**What I did** 1) ASICs have multiple internal thermal sensors. 2) With the help of configuration, a poller is introduced in Orchagent that will periodically retrieve values of these sensors with the help of SAI APIs (opencomputeproject/SAI#880). 3) These retrieved values are being populated to the state DB (In "ASIC_TEMPERATURE_INFO" table). **Why I did it** As part of ASIC Thermal Monitoring HLD.
What I did
Why I did it
As part of ASIC Thermal Monitoring HLD.
How I verified it
Tested out in below platforms.
asic_thermal_log.s6100.txt
asic_thermal_log.z9264.txt
asic_thermal_log.s5232.txt
asic_thermal_log.s6000.txt
Do not merge until sonic-net/sonic-swss-common#419 is committed and synced.
Configuration Sample(config_db.json)
Test cases and their observations
Sample RedisDB ASIC Sensors Table Output(S6100)
Output: 443 => 44.3 degC
Details if related
HLD Location: https://github.com/Azure/SONiC/blob/master/doc/asic_thermal_monitoring_hld.md