Add SAI_SWITCH_ATTR_CURRENT_TEMP to get average temperature from sensors

[padmanarayana]

Retrieve the average of sensors value readings from the ASIC.

[kcudnik]

does this mean from all available sensors? not sure if description is good enough, if you have 1 sensor with 10 degree, and 2nd with 100 then average is 55 which maybe ok but system is defenetly not ok at 100

[padmanarayana]

Yes, assuming ASIC has N internal sensors, we wanted the average of the N sensors. I can update the description. This attribute is meant to be interpreted in conjunction with the MAX_TEMP to check for deviation / discard outliers (so there are no false alarms). Alternatively, we can get the list of N values (instead of just MAX_TEMP & CURRENT_TEMP) and let the application interpret ?

[kcudnik]

updating description should be fine

[padmanarayana]

Yes, assuming ASIC has N internal sensors, we wanted the average of the N sensors. I can update the description. This attribute is meant to be interpreted in conjunction with the MAX_TEMP to check for deviation / discard outliers (so there are no false alarms). Alternatively, we can get the list of N values (instead of just MAX_TEMP & CURRENT_TEMP) and let the application interpret ? From: Kamil Cudnik <[email protected]> Sent: Sunday, October 21, 2018 1:14 PM To: opencomputeproject/SAI Cc: N, Padmanabhan; Author Subject: Re: [opencomputeproject/SAI] Add SAI_SWITCH_ATTR_CURRENT_TEMP to get average temperature from sensors (#880) [EXTERNAL EMAIL] Please report any suspicious attachments, links, or requests for sensitive information. @kcudnik commented on this pull request.

________________________________ In inc/saiswitch.h<#880 (comment)>:

@@ -409,6 +409,17 @@ typedef enum _sai_switch_attr_t

*/ SAI_SWITCH_ATTR_MAX_TEMP, + /** + * @brief The average value of the temperature + * retrieved from the switch sensors does this mean from all available sensors? not sure if description is good enough, if you have 1 sensor with 10 degree, and 2nd with 100 then average is 55 which maybe ok but system is defenetly not ok at 100 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#880 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AcaNoAYMg85GNtkcqoY4OPKfDYAVGK-Mks5unNVtgaJpZM4XyFKU>.

[padmanarayana]

As suggested in the review meeting:

1. Added SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS & SAI_SWITCH_ATTR_TEMP_LIST.
2. Renamed SAI_SWITCH_ATTR_CURRENT_TEMP as SAI_SWITCH_ATTR_AVERAGE_TEMP.